Date: Fri, 12 Jul 2002 05:20:12 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Mike Barcroft <mike@FreeBSD.ORG> Cc: Giorgos Keramidas <keramida@FreeBSD.ORG>, <current@FreeBSD.ORG> Subject: Re: sparc64 tinderbox failure Message-ID: <20020712050755.N25069-100000@gamplex.bde.org> In-Reply-To: <20020711005344.F89841@espresso.q9media.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 11 Jul 2002, Mike Barcroft wrote:
> Giorgos Keramidas <keramida@FreeBSD.org> writes:
> > Whoever fixes this, and however we agree to fix it,
> > should also remember to close the bin/40382 PR.
>
> Comments on the attached, untested patch?
> Disable fatal warnings during bootstrap, build, and cross tools
> phase of world.
The setting of NO_WERROR belongs in [BTX]MAKE if anywhere. This is
already done for [BX]MAKE but not for TMAKE. However, I don't like
turning off warnings for any of these. Warnings for these stages may
be even more important and should be less likely than warnings for
building the final world, since it is very important for basic tools
to be correct and for their source to be careful about portabilty
issues.
> Index: Makefile.inc1
> ===================================================================
> RCS file: /work/repo/src/Makefile.inc1,v
> retrieving revision 1.294
> diff -u -r1.294 Makefile.inc1
> --- Makefile.inc1 1 Jul 2002 17:51:43 -0000 1.294
> +++ Makefile.inc1 11 Jul 2002 04:50:02 -0000
> @@ -589,8 +589,8 @@
> ${_cxx_consumers} gnu/usr.bin/texinfo
> cd ${.CURDIR}/${_tool}; \
> ${MAKE} DIRPRFX=${_tool}/ obj; \
> - ${MAKE} DIRPRFX=${_tool}/ depend; \
> - ${MAKE} DIRPRFX=${_tool}/ all; \
> + ${MAKE} DIRPRFX=${_tool}/ NO_WERROR=true depend; \
> + ${MAKE} DIRPRFX=${_tool}/ NO_WERROR=true all; \
> ${MAKE} DIRPRFX=${_tool}/ DESTDIR=${MAKEOBJDIRPREFIX} install
> .endfor
> ...
This also has some style bugs :). Any setting of NO_WERROR turns it on,
so setting it to different spellings of boolean true is just confusing.
It is set correctly for for [BX]MAKE.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020712050755.N25069-100000>