From owner-freebsd-gecko@FreeBSD.ORG  Mon Nov 25 12:20:22 2013
Return-Path: <owner-freebsd-gecko@FreeBSD.ORG>
Delivered-To: gecko@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id CE234EAF
 for <gecko@FreeBSD.org>; Mon, 25 Nov 2013 12:20:22 +0000 (UTC)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 295792588
 for <gecko@FreeBSD.org>; Mon, 25 Nov 2013 12:20:21 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id OAA20013
 for <gecko@FreeBSD.org>; Mon, 25 Nov 2013 14:20:20 +0200 (EET)
 (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1Vkv9I-000MFu-2f
 for gecko@FreeBSD.org; Mon, 25 Nov 2013 14:20:20 +0200
Message-ID: <5293404C.7080102@FreeBSD.org>
Date: Mon, 25 Nov 2013 14:19:24 +0200
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.1.0
MIME-Version: 1.0
To: gecko@FreeBSD.org
Subject: Re: firefox (gecko) and DEBUG option
References: <529326C3.5000200@FreeBSD.org>
In-Reply-To: <529326C3.5000200@FreeBSD.org>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=x-viet-vps
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-gecko@freebsd.org
X-Mailman-Version: 2.1.16
Precedence: list
List-Id: Gecko Rendering Engine issues <freebsd-gecko.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-gecko>,
 <mailto:freebsd-gecko-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gecko/>
List-Post: <mailto:freebsd-gecko@freebsd.org>
List-Help: <mailto:freebsd-gecko-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gecko>,
 <mailto:freebsd-gecko-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Nov 2013 12:20:22 -0000

on 25/11/2013 12:30 Andriy Gapon said the following:
> In www/firefox port DEBUG option has the following description:
>  DEBUG             Install debug symbols
> This seems to be factually incorrect.  I see in bsd.gecko.mk that the option
> affects the following things:
> 
> .if ${PORT_OPTIONS:MDEBUG}
> MOZ_OPTIONS+=   --enable-debug --disable-release
> .else
> ...
> 
> .if ${PORT_OPTIONS:MLOGGING} || ${PORT_OPTIONS:MDEBUG}
> MOZ_OPTIONS+=   --enable-logging
> .else
> ...
> 
> Despite that I see that the installed binaries are actually stripped.
> 
> Not sure what causes this but:
> 
> $ make -V MOZ_OPTIONS
> ... *--enable-debug* --disable-release --enable-logging --disable-profiling
> --disable-tests *--enable-strip* *--enable-install-strip*
> 
> This is somewhat weird because:
> $ echo "<$(make -V STRIP)>"
> <>

It seems that at the time when bsd.gecko.mk is included (from bsd.port.mk via
bsd.port.pre.mk), WITH_DEBUG is not set yet.  So, STRIP is at its default value
and thus the stripping options are not set correctly.  Later, when bsd.port.mk
is included via bsd.port.post.mk STRIP gets reset.
Perhaps the easiest solution would be to explicitly reset STRIP in bsd.gecko.mk
when DEBUG option is set.  Similarly to how it is done for the profiling option.

-- 
Andriy Gapon