Date: Thu, 6 Jun 2002 10:31:52 -0700 From: "David O'Brien" <obrien@FreeBSD.ORG> To: "Tim J. Robbins" <tjr@FreeBSD.ORG> Cc: "Andrey A. Chernov" <ache@nagual.pp.ru>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/uniq uniq.c Message-ID: <20020606103152.D89287@dragon.nuxi.com> In-Reply-To: <20020606202942.A45282@treetop.robbins.dropbear.id.au>; from tjr@FreeBSD.ORG on Thu, Jun 06, 2002 at 08:29:42PM %2B1000 References: <200206060313.g563DAi26751@freefall.freebsd.org> <20020606031545.GA83612@nagual.pp.ru> <20020606161843.A44561@treetop.robbins.dropbear.id.au> <20020606083246.GA85860@nagual.pp.ru> <20020606192402.A45186@treetop.robbins.dropbear.id.au> <20020606100352.GA86621@nagual.pp.ru> <20020606202942.A45282@treetop.robbins.dropbear.id.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 06, 2002 at 08:29:42PM +1000, Tim J. Robbins wrote:
> > Please back it out. It break equality. Think about ss.
>
> Supply a test case and perhaps I shall.
..snip..
> This behavior is simply not correct, and the bug lies in FreeBSD's old
> uniq implementation, not GNU sort.
>
> I shall not back this change out.
Uh Tim, you need to back it out and do it now. *YOU* backed out ache's
rev 1.7 (it seems w/o discussion):
----------------------------
revision 1.7
date: 1999-10-24 04:08:15; author: ache; state: Exp; lines: +18 -4
Use strcoll to provide the same results as sort and comm
Use LINE_MAX for max line size (as comm does)
----------------------------
Ache knows a hell of a lot more about locale issues than us native
English speakers do (ache vs. CJK people is an equal battle). He should
be listened to in these cases.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020606103152.D89287>