From owner-cvs-src@FreeBSD.ORG Tue Sep 18 20:27:20 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ED5A216A41A; Tue, 18 Sep 2007 20:27:20 +0000 (UTC) (envelope-from bmah@freebsd.org) Received: from a.mail.sonic.net (a.mail.sonic.net [64.142.16.245]) by mx1.freebsd.org (Postfix) with ESMTP id D4D5B13C48A; Tue, 18 Sep 2007 20:27:20 +0000 (UTC) (envelope-from bmah@freebsd.org) Received: from dhcp-1-248.packetdesign.com (firewall-gw-dirty-n.packetdesign.com [65.87.20.98]) (authenticated bits=0) by a.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with ESMTP id l8IKRKe6021565 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 18 Sep 2007 13:27:20 -0700 Message-ID: <46F03493.7050808@freebsd.org> Date: Tue, 18 Sep 2007 13:26:59 -0700 From: "Bruce A. Mah" User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: Scott Long References: <200709180420.l8I4KMFG057365@repoman.freebsd.org> <20070918145953.GW79542@deviant.kiev.zoral.com.ua> <46F02B62.8080504@samsco.org> In-Reply-To: <46F02B62.8080504@samsco.org> X-Enigmail-Version: 0.95.3 OpenPGP: id=5ba052c3 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig1E796523A547853458C33860" Cc: Kostik Belousov , cvs-src@freebsd.org, Tim Kientzle , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libarchive archive_write_disk.c src/lib/libarchive/test test_write_disk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2007 20:27:21 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1E796523A547853458C33860 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable If memory serves me right, Scott Long wrote: > Kostik Belousov wrote: >> On Tue, Sep 18, 2007 at 04:20:21AM +0000, Tim Kientzle wrote: >>> kientzle 2007-09-18 04:20:21 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> lib/libarchive archive_write_disk.c=20 >>> lib/libarchive/test test_write_disk.c=20 >>> Log: >>> Correct the return value from archive_write_data() >>> (when used to restore files to disk) to match: >>> * The documentation >>> * The return values of this function when used >>> to write files into an archive. >>> =20 >>> Approved by: re (bmah) >>> Pointy hat: \me >>> MFC after: 5 days >>> =20 >>> Revision Changes Path >>> 1.15 +7 -4 src/lib/libarchive/archive_write_disk.c >>> 1.4 +26 -1 src/lib/libarchive/test/test_write_disk.c [snip] >> Stop in /usr/ports/audio/sdl_mixer. >> *** Error code 1 >> >> It seems that tar is broken. >=20 > I think this patch needs to be backed out until further review is=20 > obtained. This isn't a good time to leave things in a broken state for= =20 > a week while we try to figure out the "right" thing to do. Just back i= t > out to a known good state, then discuss and argue at your leisure. With my RE hat on, I've backed out this commit. Bruce. --------------enig1E796523A547853458C33860 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFG8DST2MoxcVugUsMRAioqAKDMB125+Lm0GatJNAfhLI1h1upG+wCfXiy8 uluRtjCsuaq1GqPo4HK9vtI= =mnt0 -----END PGP SIGNATURE----- --------------enig1E796523A547853458C33860--