From owner-freebsd-multimedia@FreeBSD.ORG  Fri Aug  3 22:02:17 2012
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
Delivered-To: freebsd-multimedia@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1896F106568A
	for <freebsd-multimedia@freebsd.org>;
	Fri,  3 Aug 2012 22:02:17 +0000 (UTC)
	(envelope-from clbuisson@orange.fr)
Received: from smtp.smtpout.orange.fr (smtp10.smtpout.orange.fr
	[80.12.242.132])
	by mx1.freebsd.org (Postfix) with ESMTP id AA21E8FC14
	for <freebsd-multimedia@freebsd.org>;
	Fri,  3 Aug 2012 22:02:16 +0000 (UTC)
Received: from localhost ([92.136.21.238]) by mwinf5d33 with ME
	id iMud1j00558CYNs03MueS7; Fri, 03 Aug 2012 23:54:39 +0200
Message-ID: <501C489C.1010405@orange.fr>
Date: Fri, 03 Aug 2012 23:54:36 +0200
From: Claude Buisson <clbuisson@orange.fr>
User-Agent: Mozilla/5.0 (X11; FreeBSD i386;
	rv:10.0.6esrpre) Gecko/20120731 Thunderbird/10.0.6
MIME-Version: 1.0
To: nox@jelal.kn-bremen.de
Content-Type: multipart/mixed; boundary="------------080307070906060509000705"
Cc: freebsd-multimedia@freebsd.org
Subject: VLC 2.0.3
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Aug 2012 22:02:17 -0000

This is a multi-part message in MIME format.
--------------080307070906060509000705
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

I have done a few tests with VLC 2.0.3 and your patch (005), on 9.0-STABLE (svn
r236523) i386, with a port tree mainly from 2012/05/28 (of course this needed
some tweaks, as this tree does not support options ng). The build was done with
gcc 4.6.3 (lang/gcc).

No fancy test, only listening some CDs and watching some DVDs. Everything tested
was OK.

For a build with SKINS, the compilation failed with:

x11/x11_window.cpp: In constructor 'X11Window::X11Window(intf_thread_t*, \
    GenericWindow&, X11Display&, bool, bool, X11Window*, \
    GenericWindow::WindowType_t)':
x11/x11_window.cpp:202:25: error: '_POSIX_HOST_NAME_MAX' was not declared in \
    this scope

which is corrected by the attached patch. See also:

http://permalink.gmane.org/gmane.comp.video.videolan.vlc.scm/8740

Thanks for your work,

Claude Buisson

--------------080307070906060509000705
Content-Type: text/plain;
 name="patch-modules-gui-skins2-x11-x11_window.cpp"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="patch-modules-gui-skins2-x11-x11_window.cpp"

--- modules/gui/skins2/x11/x11_window.cpp.orig	2011-12-08 19:00:26.000000000 +0100
+++ modules/gui/skins2/x11/x11_window.cpp	2012-08-03 15:47:39.000000000 +0200
@@ -36,6 +36,7 @@
 #include "x11_factory.hpp"

 #include <assert.h>
+#include <limits.h>

 X11Window::X11Window( intf_thread_t *pIntf, GenericWindow &rWindow,
                       X11Display &rDisplay, bool dragDrop, bool playOnDrop,

--------------080307070906060509000705--