Date: Sat, 14 Aug 2010 12:23:03 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Matthias Andree <mandree@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/games Makefile ports/games/atanks Makefile distinfo pkg-descr pkg-plist ports/games/atanks/files patch-Makefile patch-src_files.cpp Message-ID: <20100814122303.GA69635@FreeBSD.org> In-Reply-To: <201008141202.o7EC2mvm018841@repoman.freebsd.org> References: <201008141202.o7EC2mvm018841@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 14, 2010 at 12:02:48PM +0000, Matthias Andree wrote: > mandree 2010-08-14 12:02:48 UTC > > FreeBSD ports repository > > Modified files: > games Makefile > Added files: > games/atanks Makefile distinfo pkg-descr pkg-plist > games/atanks/files patch-Makefile patch-src_files.cpp > Log: > Add new port games/atanks. It is usually nice to briefly mention in the commit log some details about the port and/or why it might be interesting to take a look at. Quoting entire pkg-message is probably unnecessary, but simply reiterating port name (that is, providing zero information) is certainly not enough; consider at least quoting COMMENT line next time. Also, post-patch: section is incorrectly indented, and setting DISTNAME value is no-op (thus should be dropped). > Submitted by: Jesse Smith <jessefrgsmith@yahoo.ca> > PR: ports/147768 Try to indent tag values to ease the reading, thanks. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100814122303.GA69635>