Date: Thu, 12 Jul 2007 01:20:26 -0700 From: "Jack Vogel" <jfvogel@gmail.com> To: "Robert Watson" <rwatson@freebsd.org> Cc: Jack F Vogel <jfv@freebsd.org>, cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/ixgbe LICENSE ixgbe.c ixgbe.h ixgbe_82598.c ixgbe_api.c ixgbe_api.h ixgbe_common.c ixgbe_common.h ixgbe_osdep.h ixgbe_phy.c ixgbe_phy.h ixgbe_type.h Message-ID: <2a41acea0707120120w38d67d7fsf01d573329814c4@mail.gmail.com> In-Reply-To: <20070712085707.G68820@fledge.watson.org> References: <200707112303.l6BN3HPu010363@repoman.freebsd.org> <20070712085707.G68820@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Sorry, what happened was the first commit accidentally only included the conf files, so I followed this up right after with a sheepish joke, I should've added the comment from the first, my bad :( On 7/12/07, Robert Watson <rwatson@freebsd.org> wrote: > On Wed, 11 Jul 2007, Jack F Vogel wrote: > > > jfv 2007-07-11 23:03:17 UTC > > > > FreeBSD src repository > > > > Added files: > > sys/dev/ixgbe LICENSE ixgbe.c ixgbe.h ixgbe_82598.c > > ixgbe_api.c ixgbe_api.h ixgbe_common.c > > ixgbe_common.h ixgbe_osdep.h ixgbe_phy.c > > ixgbe_phy.h ixgbe_type.h > > Log: > > Add the actual source too :) > > This commit message leaves a lot to be desired, especially for 1.1 revisions. > I think you should consider a forced commit that mentions something more than > that the files are source code -- perhaps a 2-3 level sentence summary of what > the actual change meant. Remember that changes on other files, such as the > conf files you touched in the earlier commit, won't appear in "cvs log" of > these files. > > Robert N M Watson > Computer Laboratory > University of Cambridge >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2a41acea0707120120w38d67d7fsf01d573329814c4>