Date: Sun, 1 Feb 2015 17:45:23 -0700 From: Will Andrews <will@firepipe.net> To: Davide Italiano <davide@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Steven Hartland <smh@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org> Subject: Re: svn commit: r278040 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <CADBaqmgHw4EW4LAbjDF_-91SYrpe6%2BYY7FytR_aZX185ye8mfA@mail.gmail.com> In-Reply-To: <CACYV=-G-NeEAn1ewQowzX34PgA5tum8jG6-rdt%2BQPuo4-ytBqg@mail.gmail.com> References: <201502020017.t120Hb2g095087@svn.freebsd.org> <CACYV=-G-NeEAn1ewQowzX34PgA5tum8jG6-rdt%2BQPuo4-ytBqg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, February 1, 2015, Davide Italiano <davide@freebsd.org> wrote: > On Mon, Feb 2, 2015 at 1:17 AM, Steven Hartland <smh@freebsd.org > <javascript:;>> wrote: > > Author: smh > > Date: Mon Feb 2 00:17:36 2015 > > New Revision: 278040 > > URL: https://svnweb.freebsd.org/changeset/base/278040 > > > > Log: > > Prevent inlining txg_quiesce > > > > This allows dtrace to monitor the calls to txg_quiesce which can be > really > > helpful. > > > > Also standardise __noinline order for arc_kmem_reap_now. > > > > Sponsored by: Multiplay > > > > > > I found this while I was at iXsystems, trying to port Richard Elling's > arc statistics utility to FreeBSD. > I do not disagree with the change in theory, but I never committed > this because I was worried of performance penalty. > Last time I checked Solaris/Illumos actually do not inline this > function without any particular directive (I guess this is mostly due > to difference in toolchain, in particular in the compiler), so it > shouldn't be a big deal, but if you have time, do you mind to check > the penalty introduced, if any, is negligible? > It should be negligible. The function is only called once per txg, which generally is only supposed to happen about 1-0.2Hz. --Will.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADBaqmgHw4EW4LAbjDF_-91SYrpe6%2BYY7FytR_aZX185ye8mfA>