From owner-freebsd-bugs@FreeBSD.ORG  Fri Feb  9 20:20:07 2007
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 206B816A403
	for <freebsd-bugs@hub.freebsd.org>;
	Fri,  9 Feb 2007 20:20:07 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40])
	by mx1.freebsd.org (Postfix) with ESMTP id D1ADA13C491
	for <freebsd-bugs@hub.freebsd.org>;
	Fri,  9 Feb 2007 20:20:06 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l19KK66n014528
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 9 Feb 2007 20:20:06 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l19KK6Wf014527;
	Fri, 9 Feb 2007 20:20:06 GMT (envelope-from gnats)
Resent-Date: Fri, 9 Feb 2007 20:20:06 GMT
Resent-Message-Id: <200702092020.l19KK6Wf014527@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Kevin Way<kevin@insidesystems.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 05A6616A402
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri,  9 Feb 2007 20:11:38 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id E939013C461
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri,  9 Feb 2007 20:11:37 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l19KBb6O073362
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 9 Feb 2007 20:11:37 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l19KBbmC073361;
	Fri, 9 Feb 2007 20:11:37 GMT (envelope-from nobody)
Message-Id: <200702092011.l19KBbmC073361@www.freebsd.org>
Date: Fri, 9 Feb 2007 20:11:37 GMT
From: Kevin Way<kevin@insidesystems.net>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.0
Cc: 
Subject: misc/108988: [patch] RELENG_6_2 rc.d/jail unaliases incorrectly,
	on failed startup
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Feb 2007 20:20:07 -0000


>Number:         108988
>Category:       misc
>Synopsis:       [patch] RELENG_6_2 rc.d/jail unaliases incorrectly, on failed startup
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 09 20:20:06 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Kevin Way
>Release:        RELENG_6_2
>Organization:
InsideSystems, Inc.
>Environment:
FreeBSD bluefin.insidesystems.net 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Fri Jan 12 08:43:30 UTC 2007     root@portnoy.cse.buffalo.edu:/usr/obj/usr/src/sys/SMP  amd64
>Description:
If a jail has an error while setting up, rc.d/jail can end up removing the wrong IP address, becausese it calls ifconfig -alias with an incorrect variable.
>How-To-Repeat:
setup a jail that fails on startup.
>Fix:
--- jail.orig   Fri Feb  9 15:00:20 2007
+++ jail        Fri Feb  9 15:02:59 2007
@@ -331,8 +331,8 @@
                                echo ${_jail_id} > /var/run/jail_${_jail}.id
                        else
                                jail_umount_fs
-                               if [ -n "${jail_interface}" ]; then
-                                       ifconfig ${jail_interface} -alias ${jail_ip}
+                               if [ -n "${_interface}" ]; then
+                                       ifconfig ${_interface} -alias ${_ip}
                                fi
                                echo " cannot start jail \"${_jail}\": "
                                tail +2 ${_tmp_jail}

>Release-Note:
>Audit-Trail:
>Unformatted: