From owner-freebsd-bugs@FreeBSD.ORG Fri Jan 9 12:00:10 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D76E110656C2 for ; Fri, 9 Jan 2009 12:00:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C333E8FC12 for ; Fri, 9 Jan 2009 12:00:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n09C0AhQ045009 for ; Fri, 9 Jan 2009 12:00:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n09C0AFI045008; Fri, 9 Jan 2009 12:00:10 GMT (envelope-from gnats) Date: Fri, 9 Jan 2009 12:00:10 GMT Message-Id: <200901091200.n09C0AFI045008@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Jaakko Heinonen Cc: Subject: Re: bin/124724: [patch] netstat(1): netstat coredump on -stable X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Jaakko Heinonen List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jan 2009 12:00:12 -0000 The following reply was made to PR bin/124724; it has been noted by GNATS. From: Jaakko Heinonen To: Li yonggang Cc: bug-followup@FreeBSD.org Subject: Re: bin/124724: [patch] netstat(1): netstat coredump on -stable Date: Fri, 9 Jan 2009 13:51:16 +0200 Hi, On 2009-01-09, Li yonggang wrote: > I think the root cause is that netstat does not check if the input is > correct. so I think we should add some input checker while remove > the > BACKWARD_PATIBILITY code, which will lead to use incorrect input. Did you see my analysis and the patch for the problem? http://lists.freebsd.org/pipermail/freebsd-bugs/2008-June/031294.html Your patch doesn't address the "netstat -m -N foo" case. It also removes the backward compatibility code. I don't know if that code has any real value but I don't see need to remove it to fix this bug. -- Jaakko