Date: Thu, 29 Jun 2017 11:04:53 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 219687] [NEW PORT] net/google-compute-engine: User daemon for Google Compute Engine Message-ID: <bug-219687-13-iY63B2cvQl@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-219687-13@https.bugs.freebsd.org/bugzilla/> References: <bug-219687-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D219687 Kubilay Kocak <koobs@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |python@FreeBSD.org Status|New |Open Summary|[NEW PORT] |[NEW PORT] |net/google-compute-engine: |net/google-compute-engine: |user daemon for Google |User daemon for Google |Compute Engine |Compute Engine Flags| |maintainer-feedback?(helen. | |koike@collabora.com) Keywords| |feature, needs-patch, | |needs-qa Priority|--- |Normal Assignee|freebsd-ports-bugs@FreeBSD. |koobs@FreeBSD.org |org | --- Comment #8 from Kubilay Kocak <koobs@FreeBSD.org> --- Thank you for your new port contribution Helen. Pending further review, initial review items (needing updated patch) are: - Add missing PKGNAMEPREFIX=3D${PYTHON_PKGNAMEPREFIX} - Missing secondary 'python' virtual category in CATEGORIES=20 - Add USE_PYTHON=3Dconcurrent if the port is multiple python version concur= rent installation safe (all files are uniquely named and dont conflict) - Use 'CHEESESHOP' (PyPI) as MASTER_SITES unless there is a compelling reas= on not to (for instance, test or other important files missing from source distribution on PyPI) - Add test support (using do-test: target), adding TEST_DEPENDS (py.test, e= tc as per setup.py/tox.ini) and executing ${PYTHON_CMD} -m pytest or ${PYTHON_= CMD} setup.py test if supported. It's OK if not all test dependencies have been ported yet, just add the ones that have, adding comments for the ones that havent. - setuptools appears (in setup.py) as an install_requires (RUN_DEPENDS) not= a setup_requires (BUILD_DEPENDS) as in the patch. I don't know why its explic= itly in install_requires though. - Add LICENSE_FILE=3D${WRKSRC}/path/to/license when one exists in the distribution file - netifaces/netaddr don't appear as setup.py (compulsory) or tox.ini (potentially optional) dependencies. Can you elaborate on their source and function? If possible (highly desirable/recommended), please provide as an attachment= the results of the package test suite as well. For more information on creating ports for Python packages, see: https://wiki.freebsd.org/Python/PortsPolicy --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-219687-13-iY63B2cvQl>