Date: Tue, 03 Jun 2008 13:49:59 -0700 From: Doug Barton <dougb@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/bind config.h src/lib/bind/bind port_after.h port_before.h src/lib/bind/isc/isc platform.h Message-ID: <4845AE77.8040508@FreeBSD.org> In-Reply-To: <200806031628.16352.jhb@freebsd.org> References: <200806030543.m535hfjh085481@repoman.freebsd.org> <200806031611.53492.jhb@freebsd.org> <200806031628.16352.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote:
> On Tuesday 03 June 2008 04:11:53 pm John Baldwin wrote:
>> On Tuesday 03 June 2008 01:43:27 am Doug Barton wrote:
>>> dougb 2008-06-03 05:43:41 UTC
>>>
>>> FreeBSD src repository
>>>
>>> Modified files: (Branch: RELENG_6)
>>> lib/bind config.h
>>> lib/bind/bind port_after.h port_before.h
>>> lib/bind/isc/isc platform.h
>>> Log:
>>> SVN rev 179505 on 2008-06-03 05:43:27Z by dougb
>>>
>>> Changes to generated files related to the 9.3.5 update.
>>>
>>> Revision Changes Path
>>> 1.1.4.3 +7 -0 src/lib/bind/bind/port_after.h
>>> 1.1.4.3 +10 -0 src/lib/bind/bind/port_before.h
>>> 1.2.2.5 +8 -10 src/lib/bind/config.h
>>> 1.1.4.3 +8 -3 src/lib/bind/isc/isc/platform.h
>> Perhaps src/lib/bind/bind/config.h needs updating? It appears that
>> HAVE_MEMMOVE isn't set, and so this new part of port_before.h is breaking
> the
>> build:
>>
>> +#ifndef HAVE_MEMMOVE
>> +#define memmove(a,b,c) bcopy(b,a,c)
>> +#endif
>
> I'm trying this patch to config.h based on comparing the changes to
> src/contrib/bind9/lib/bind/config.h.in:
>
> --- //depot/yahoo/ybsd_6/src/lib/bind/bind/config.h
> +++ /home/jhb/work/y/p4/ybsd_6/src/lib/bind/bind/config.h
> @@ -14,6 +14,8 @@
> /* #undef POSIX_GETPWNAM_R */
> /* #undef POSIX_GETGRGID_R */
> /* #undef POSIX_GETGRNAM_R */
> +#define HAVE_MEMMOVE
> +#define HAVE_MEMCHR
Yeah, I think that actually is the problem. The configure script for
the port got that right, but when I ran configure with the sources in
the base it missed it. I was trying to figure out why but I'm going to
go ahead and test this patch now and investigate more while the world
builds.
Thanks for looking at this. My buildworld completed successfully last
night before I committed, I'm also trying to figure out what was
different between then and now, but I've got a sick little one at home
today and that's not helping.
Doug
--
This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4845AE77.8040508>