From owner-freebsd-stable@FreeBSD.ORG Sun Jan 20 20:53:24 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9887C16A47A for ; Sun, 20 Jan 2008 20:53:24 +0000 (UTC) (envelope-from jakob@dev.citybikes.cz) Received: from dev.citybikes.cz (r5o136.net.upc.cz [86.49.14.136]) by mx1.freebsd.org (Postfix) with ESMTP id 21A4113C467 for ; Sun, 20 Jan 2008 20:53:23 +0000 (UTC) (envelope-from jakob@dev.citybikes.cz) Received: from dev.citybikes.cz (localhost [127.0.0.1]) by dev.citybikes.cz (8.14.2/8.14.2) with ESMTP id m0KKrK3w004254 for ; Sun, 20 Jan 2008 21:53:20 +0100 (CET) (envelope-from jakob@dev.citybikes.cz) Received: (from jakob@localhost) by dev.citybikes.cz (8.14.2/8.14.2/Submit) id m0KKrKid004253; Sun, 20 Jan 2008 21:53:20 +0100 (CET) (envelope-from jakob) Date: Sun, 20 Jan 2008 21:53:19 +0100 From: Jakub Siroky To: freebsd-stable@freebsd.org Message-ID: <20080120215319.2d13ca88@dev> In-Reply-To: <20080120212732.f3ea3fe1.torfinn.ingolfsen@broadpark.no> References: <4792BC5E.4030703@vwsoft.com> <20080120212732.f3ea3fe1.torfinn.ingolfsen@broadpark.no> X-Mailer: Claws Mail 3.0.2 (GTK+ 2.12.1; amd64-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: patch for review: ATI SB600 SATA AHCI X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jan 2008 20:53:24 -0000 Just my info: dmesg| grep ata atapci0: port 0xff00-0xff07,0xfe00-0xfe03,0xfd00-0xfd07,0xfc00-0xfc03,0xfb00-0xfb0f mem 0xfe02f000-0xfe02f3ff irq 22 at device 18.0 on pci0 atapci0: [ITHREAD] atapci0: AHCI Version 01.10 controller with 4 ports detected ata2: on atapci0 ata2: [ITHREAD] ata3: on atapci0 ata3: [ITHREAD] ata4: on atapci0 ata4: [ITHREAD] ata5: on atapci0 ata5: [ITHREAD] atapci1: port 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xf900-0xf90f at device 20.1 on pci0 ata0: on atapci1 ata0: [ITHREAD] acd0: DVDR at ata0-master UDMA33 acd1: DVDROM at ata0-slave UDMA33 ad4: 381553MB at ata2-master SATA300 ad8: 476940MB at ata4-master SATA300 atacontrol mode ad4: current mode = SATA300 uname -a: FreeBSD dev.citybikes.cz 7.0-RC1 FreeBSD 7.0-RC1 #4: Sun Jan 20 01:33:16 CET 2008 root@dev.citybikes.cz:/usr/build/obj/usr/build/src_releng_7_0/sys/TWINSF amd64 lshal: system.product = 'GA-MA69G-S3H' system.vendor = 'Gigabyte Technology Co., Ltd.' On Sun, 20 Jan 2008 21:27:32 +0100 Torfinn Ingolfsen wrote: > Hello, > > On Sun, 20 Jan 2008 04:13:34 +0100 > Volker wrote: > > > 6715b notebook using ATI SB-600 chipset. With stock kernel, the ATA > > I have a machine with an Asus M2A-VM HDMI motherboard[1], which also > have this chipset. > > > My patch has been tested on RELENG_7 as of 2008-01-19. Please > > review, check and test if possible. Should work on 8-CURRENT, too. > > I had to hand apply part of the patch (probably a whitespace problem > when I copied it from the mail), but it built fine. > > From dmesg, before the patch: > atapci0: port > 0xfc00-0xfc07,0xf800-0xf803,0xf400-0xf407,0xf000-0xf003,0xec00-0xec0f > mem 0xfe02f000-0xfe02f3ff irq 22 at device 18.0 on pci0 atapci0: > [ITHREAD] ata2: on atapci0 ata2: [ITHREAD] > ata3: on atapci0 > ata3: [ITHREAD] > atapci1: port > 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xe400-0xe40f at device 20.1 on > pci0 ata0: on atapci1 ata0: [ITHREAD] > acd0: DVDR at ata0-master UDMA66 > ad4: 476940MB at ata2-master UDMA33 > > From dmesg, after the patch: > tapci0: port > 0xfc00-0xfc07,0xf800-0xf803,0xf400-0xf407,0xf000-0xf003,0xec00-0xec0f > mem 0xfe02f000-0xfe02f3ff irq 22 at device 18.0 on pci0 atapci0: > [ITHREAD] atapci0: AHCI Version 01.10 controller with 4 ports > detected ata2: on atapci0 ata2: [ITHREAD] > ata3: on atapci0 > ata3: [ITHREAD] > ata4: on atapci0 > ata4: [ITHREAD] > ata5: on atapci0 > ata5: [ITHREAD] > atapci1: port > 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xe400-0xe40f at device 20.1 on > pci0 ata0: on atapci1 ata0: [ITHREAD] > acd0: DVDR at ata0-master UDMA66 > ad4: 476940MB at ata2-master SATA300 > > I haven't done any tests to see if it changes performance in any way, > at least it reports SATA 300: root@kg-vm# atacontrol mode ad4 > current mode = SATA300 > > This is on: > root@kg-vm# uname -a > FreeBSD kg-vm.kg4.no 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE #4: Sun > Jan 20 19:27:36 CET 2008 > root@kg-vm.kg4.no:/usr/obj/usr/src/sys/GENERIC amd64 > > > References: > 1) info about my machine > http://tingox.googlepages.com/asus_m2a-vm_hdmi