Date: Thu, 7 Mar 2002 02:57:20 -0800 From: "David O'Brien" <obrien@FreeBSD.org> To: Mark Murray <markm@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libcrypt crypt-md5.c crypt.c crypt.h misc.c src/secure/lib/libcrypt blowfish.c blowfish.h crypt-blowfish.c crypt-des.c Message-ID: <20020307025720.A63484@dragon.nuxi.com> In-Reply-To: <200203061718.g26HI9060426@freefall.freebsd.org>; from markm@FreeBSD.org on Wed, Mar 06, 2002 at 09:18:09AM -0800 References: <200203061718.g26HI9060426@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 06, 2002 at 09:18:09AM -0800, Mark Murray wrote: > markm 2002/03/06 09:18:09 PST > > Modified files: > lib/libcrypt crypt-md5.c crypt.c crypt.h misc.c > secure/lib/libcrypt blowfish.c blowfish.h crypt-blowfish.c > crypt-des.c > Log: > No functional change, but big code cleanup. WARNS, lint(1) and style(9). As many people have asked in the past, please commit style(9) separately from other commits. It is hard to see the WARNS/lint(1) changes from the diff. I would like to renew my opinion that WARNS/lint(1) fixes be reviewed on -audit (or -hackers) before commit. (also might want to run them on your local machine for a few days) You are changing a lot of code for reasons of quieting lint(1), which a lot of us do not agree with. And lint(1) quieting changes can easily become bugs as we saw with crypt-md5.c rev 1.9. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020307025720.A63484>