Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 Feb 2012 01:15:52 +0100
From:      Luigi Rizzo <rizzo@iet.unipi.it>
To:        Brooks Davis <brooks@freebsd.org>
Cc:        net@freebsd.org, Marcel Moolenaar <marcel@xcllnt.net>
Subject:   Re: Abstracting struct ifnet
Message-ID:  <20120221001552.GA60050@onelab2.iet.unipi.it>
In-Reply-To: <20120220231601.GA51310@lor.one-eyed-alien.net>
References:  <338757D1-6B1E-49CF-983F-5D5851066FD3@xcllnt.net> <20120220231601.GA51310@lor.one-eyed-alien.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Feb 20, 2012 at 05:16:02PM -0600, Brooks Davis wrote:
> 
> The concept seems fine to me and I like that it might simplify future
> API changes.  Have you verified that if_get_*() accessors don't add
> significant overhead?

the vast majority of these fields are only accessed in the control path,
not on each packet, so there isn't really a performance issue. Besides
they can be trivially implemted as macros or inline functions.

cheers
luigi





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120221001552.GA60050>