From owner-svn-src-stable@freebsd.org Thu Mar 15 15:33:58 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D2EDFF5ADA4; Thu, 15 Mar 2018 15:33:58 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3AB7A86D74; Thu, 15 Mar 2018 15:33:57 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w2FFXmc0093663; Thu, 15 Mar 2018 08:33:48 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w2FFXkS9093662; Thu, 15 Mar 2018 08:33:46 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201803151533.w2FFXkS9093662@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r330972 - stable/11/share/misc In-Reply-To: To: Andriy Gapon Date: Thu, 15 Mar 2018 08:33:46 -0700 (PDT) CC: Eitan Adler , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 15:33:59 -0000 > On 15/03/2018 10:30, Eitan Adler wrote: > > Author: eadler > > Date: Thu Mar 15 08:30:05 2018 > > New Revision: 330972 > > URL: https://svnweb.freebsd.org/changeset/base/330972 > > > > Log: > > MFC r303063,r311852,r311930,r317040,r320506,r321301,r325162,r326759,r329004,: > > I have never seen things like these MFC-ed before... > Should we be really doing them? Yes, imho. And the reasons may seem odd to sum, but here is my spin on this: It should not of been Eitan who did the MFC. Second, this simple document MFC is excellent training ground for a new commiter to learn how to do a MFC. Everyone should know how to do an MFC and it seems we have many (me included when I returned as my experiece was all with cvs, not svn) who do not know how to do this operation. If they mess up this simple text file it has a very low risk, and then they can learn how to do a revert and recommit! Maybe we should even add to the end of the commiters "these are the things you should do as a new committer" the merging of your info into to all supported/active releases. Which is a good opportunity for teaching how to do svn sparse checkouts as you really do not want to pull all of stable/10 out just to commit to 1 file. This file is an excellent opportunity for training, lets USE IT! Thanks, > > Add myself (stevek) as a src committer and mentor (sjg) to committers-src.dot > > > > Approved by: sjg (mentor) ... -- Rod Grimes rgrimes@freebsd.org