Date: Wed, 21 Jul 2010 17:20:05 GMT From: Alexander Best <alexbestms@uni-muenster.de> To: freebsd-amd64@FreeBSD.org Subject: Re: amd64/144405: [build] [patch] include /usr/obj/lib32 in cleanworld target on amd64 arch Message-ID: <201007211720.o6LHK5vg062056@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR amd64/144405; it has been noted by GNATS.
From: Alexander Best <alexbestms@uni-muenster.de>
To: Anonymous <swell.k@gmail.com>
Cc: bug-followup@freebsd.org
Subject: Re: amd64/144405: [build] [patch] include /usr/obj/lib32 in
cleanworld target on amd64 arch
Date: Wed, 21 Jul 2010 19:15:22 +0200
2010/7/19 Anonymous <swell.k@gmail.com>:
> Alexander Best <alexbestms@uni-muenster.de> writes:
>
>> i can't really think of a situation where somebody wants to remove all
>> the 64bit objs but keep the 32bit ones.
>
> I was concerned about cleanworld invoked by crossbuild breaking normal
> build when running concurrently but looks like that's not the case, i.e.
>
> =A0$ make cleanworld TARGET=3Di386 # /usr/obj/i386.i386/lib32/usr/src
>
> doesn't wipe out lib32 for normal build (/usr/obj/lib32/usr/src).
> Since crossbuild encloses lib32 in its OBJTREE there is no need for
> MK_LIB32 check.
cool. now all that is necessary is somebody to commit those changes.
probably the hardest part of all. ;)
cheers.
alex
>
> --- b.diff begins here ---
> diff --git a/Makefile.inc1 b/Makefile.inc1
> index 85669d5..2298eca 100644
> --- a/Makefile.inc1
> +++ b/Makefile.inc1
> @@ -1512,7 +1512,7 @@ cleanworld:
> =A0 =A0 =A0 =A0-chflags -R 0 ${OBJTREE}${.CURDIR}
> =A0 =A0 =A0 =A0rm -rf ${OBJTREE}${.CURDIR}/*
> =A0.endif
> -.if exists(${OBJTREE}/lib32${.CURDIR}) && ${MK_LIB32} !=3D "no"
> +.if exists(${OBJTREE}/lib32${.CURDIR})
> =A0 =A0 =A0 =A0-rm -rf ${OBJTREE}/lib32${.CURDIR}/*
> =A0 =A0 =A0 =A0-chflags -R 0 ${OBJTREE}/lib32${.CURDIR}
> =A0 =A0 =A0 =A0rm -rf ${OBJTREE}/lib32${.CURDIR}/*
> --- b.diff ends here ---
>
--=20
Alexander Best
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201007211720.o6LHK5vg062056>