Date: Fri, 9 Aug 2002 18:00:08 -0700 (PDT) From: Ian Dowse <iedowse@maths.tcd.ie> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/41492: Kernel Panic after cvsup'ing 8/9/02 Message-ID: <200208100100.g7A108HC005933@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/41492; it has been noted by GNATS. From: Ian Dowse <iedowse@maths.tcd.ie> To: Max Clark <max@clarksys.com> Cc: freebsd-gnats-submit@FreeBSD.org, luigi@FreeBSD.org Subject: Re: kern/41492: Kernel Panic after cvsup'ing 8/9/02 Date: Sat, 10 Aug 2002 01:51:23 +0100 In message <200208092222.g79MMFqD079052@www.freebsd.org>, Max Clark writes: > >stopped at m_freem+0x1c: cmpl $0,0(%ebx) >>How-To-Repeat: >I haven't been able to narrow the event to a specific event other than I cvsup >'d this morring after this issue (http://www.freebsd.org/cgi/query-pr.cgi?pr=4 >1459) was resolved. Try the following patch. A recent commit broke the long-standing assumption that it is safe to pass NULL into m_freem(). Ian Index: uipc_mbuf.c =================================================================== RCS file: /home/iedowse/CVS/src/sys/kern/uipc_mbuf.c,v retrieving revision 1.51.2.17 diff -u -r1.51.2.17 uipc_mbuf.c --- uipc_mbuf.c 9 Aug 2002 02:11:08 -0000 1.51.2.17 +++ uipc_mbuf.c 10 Aug 2002 00:47:30 -0000 @@ -703,7 +703,7 @@ { int s = splimp(); - if (mcl_pool_now < mcl_pool_max && m->m_next == NULL && + if (mcl_pool_now < mcl_pool_max && m && m->m_next == NULL && (m->m_flags & (M_PKTHDR|M_EXT)) == (M_PKTHDR|M_EXT) && m->m_type == MT_DATA && M_EXT_WRITABLE(m) ) { if (m->m_pkthdr.aux) { To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200208100100.g7A108HC005933>