Date: Tue, 17 Sep 2019 16:18:10 -0700 From: Conrad Meyer <cem@freebsd.org> To: Toomas Soome <tsoome@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r352451 - head/stand/libsa Message-ID: <CAG6CVpW5V7%2BkZZyMBuF_8A3Ns3ETTfaBwqzBqhSq7Ve%2BPJoDJw@mail.gmail.com> In-Reply-To: <201909171616.x8HGGlkb066218@repo.freebsd.org> References: <201909171616.x8HGGlkb066218@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Well, hang on; it's also perfectly legal for a malloc implementation to return NULL for requests of zero bytes. You can access exactly the number of bytes requested in the allocation; and free(NULL) works as expected. NULL (0) is also aligned to any size you could want. Best, Conrad On Tue, Sep 17, 2019 at 9:16 AM Toomas Soome <tsoome@freebsd.org> wrote: > > Author: tsoome > Date: Tue Sep 17 16:16:46 2019 > New Revision: 352451 > URL: https://svnweb.freebsd.org/changeset/base/352451 > > Log: > loader: revert r352421 > > As insisted by kib, malloc(0) is quite legal. > > Modified: > head/stand/libsa/zalloc_malloc.c > > Modified: head/stand/libsa/zalloc_malloc.c > ============================================================================== > --- head/stand/libsa/zalloc_malloc.c Tue Sep 17 15:53:40 2019 (r352450) > +++ head/stand/libsa/zalloc_malloc.c Tue Sep 17 16:16:46 2019 (r352451) > @@ -73,9 +73,6 @@ Malloc_align(size_t bytes, size_t alignment) > { > Guard *res; > > - if (bytes == 0) > - return (NULL); > - > #ifdef USEENDGUARD > bytes += MALLOCALIGN + 1; > #else
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpW5V7%2BkZZyMBuF_8A3Ns3ETTfaBwqzBqhSq7Ve%2BPJoDJw>