From owner-freebsd-scsi@FreeBSD.ORG Fri Mar 5 01:37:33 2010 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 680EA106566C for ; Fri, 5 Mar 2010 01:37:33 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-iw0-f173.google.com (mail-iw0-f173.google.com [209.85.223.173]) by mx1.freebsd.org (Postfix) with ESMTP id 2C11C8FC1B for ; Fri, 5 Mar 2010 01:37:32 +0000 (UTC) Received: by iwn3 with SMTP id 3so2328848iwn.13 for ; Thu, 04 Mar 2010 17:37:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type; bh=ROu3c+F+IKmm/VquIxuH77JNImfCrUnrbEbt3hIpaiI=; b=jT/5CeCO/mxCF/Up+KGRViBkVqEoh8yL54243vf+8e4Amlv0j/YPztsvzXhTaXVdtp MFYrfkFMEYnd6n0ulW7RQSeB6F2kOlaWJj+jk085Qr75+fwK36M4EB86SyMelNSLX17w C7vZnpYLEff+SJ8G/CWepzIC/pv/GIJ9hy05c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=Wac+WImhDA6g6F3JgaLjInC+3WoEN8AsaUSv3wuLeNcOdf8h7kxz9epZ7BGmmxlx6I u3ZALpP1KXLoUi2Tt5WpsFbo2R6+B+hqHGRIn/jZQ+opkfNOjYu4J8yVm246wIgAE+cy KyZWqWSO/1qhS5oLkIxFafyOqF6WFIw3vhowk= MIME-Version: 1.0 Sender: asmrookie@gmail.com Received: by 10.231.160.205 with SMTP id o13mr1099604ibx.13.1267753043951; Thu, 04 Mar 2010 17:37:23 -0800 (PST) In-Reply-To: <4B901419.8060800@feral.com> References: <3bbf2fe11002281655i61a5f0a0if3f381ad0c4a1ef8@mail.gmail.com> <4B8EDAE8.3080401@feral.com> <3bbf2fe11003031357o518d6028m8157d9110a9122f3@mail.gmail.com> <4B8EF128.8050704@feral.com> <3bbf2fe11003031532u2207eb55h19c3a045215a7d84@mail.gmail.com> <4B8EF336.80107@feral.com> <3bbf2fe11003031547kd5f7314t3d83b2bde06c1c2f@mail.gmail.com> <4B8EF990.5030407@feral.com> <3bbf2fe11003031607wa3727b5ke89bc2a909d4d6a6@mail.gmail.com> <4B901419.8060800@feral.com> Date: Fri, 5 Mar 2010 02:37:23 +0100 X-Google-Sender-Auth: dc7ed325c18b956a Message-ID: <3bbf2fe11003041737p30690522ya81e1b8f4bd6bbf9@mail.gmail.com> From: Attilio Rao To: mj@feral.com Content-Type: text/plain; charset=UTF-8 Cc: freebsd-scsi@freebsd.org Subject: Re: How is supposed to be protected the units list? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2010 01:37:33 -0000 2010/3/4 Matthew Jacob : > The referred to patch at least got me out of panic case :-).. > > > http://people.freebsd.org/~mjacob/scsi_da.c.patch Yes, honestly the main intent of this patch is to offer a stable ground for correct handling of periph. When looking about refcounting them correctly, the main problem is that there was no initial condition assuring safety, and the initial patch should address this, but I'm sure there are places where periph refcount is not handled correctly and this may be one. Thanks, Attilio PS: Sorry for late responses since now, but I'm mostly away. -- Peace can only be achieved by understanding - A. Einstein