Date: Sat, 6 Jan 2001 14:21:01 +0100 From: Jeroen Ruigrok van der Werven <asmodai@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: Alexander Langer <alex@big.endian.de>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules/s3 Makefile Message-ID: <20010106142101.B49254@lucifer.bart.nl> In-Reply-To: <Pine.BSF.4.21.0101062324140.18823-100000@besplex.bde.org>; from bde@zeta.org.au on Sat, Jan 06, 2001 at 11:39:35PM %2B1100 References: <20010106125323.A2966@cichlids.cichlids.com> <Pine.BSF.4.21.0101062324140.18823-100000@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-On [20010106 13:40], Bruce Evans (bde@zeta.org.au) wrote: >On Sat, 6 Jan 2001, Alexander Langer wrote: > >> Thus spake Jeroen Ruigrok van der Werven (asmodai@FreeBSD.org): >> >> > We don't use += for SRCS in Makefiles, we simply use the >> > line continuation character and state the rest of the sourcefiles >> > on the next line. >> >> Uhm: >> alex:/sys/modules $ grep 'SRCS[^\t ]+=' */Makefile | wc -l >> 38 > >Correcting the pattern to 'SRCS[ ]*+=' (hard tab in this) gives >a count of 127. I was and am aware of that, however, when I make such a commit I want to touch/correct them in one sweep. Personally I am a great bastard when it comes to consistency and/or consistent style. >These are mostly style bugs, although not as bad as non-null whitespace >between variables and assignment operators (the bad example of >modules/fxp/Makefile seems to have been cloned all over). `+=' may >be right for separating logically diferent parts of SRCS, e.g., generated >header files from non-generated .c files. Or the files which need to be included depending on which piece is #defined as with most NIC Makefiles. -- Jeroen Ruigrok van der Werven VIA Net.Works The Netherlands BSD: Technical excellence at its best Network- and systemadministrator D78D D0AD 244D 1D12 C9CA 7152 035C 1138 546A B867 I know your name, but I am just your Fallen Angel of Doom... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010106142101.B49254>