Date: Tue, 19 Mar 2002 12:49:42 +0200 From: Peter Pentchev <roam@ringlet.net> To: Kyle Martin <mkm@ieee.org> Cc: freebsd-ports@freebsd.org Subject: Re: [NEW PORT] devel/cmake Message-ID: <20020319124942.A4570@straylight.oblivion.bg> In-Reply-To: <20020317001523.A95530@marvin.bsdng.org>; from mkm@ieee.org on Sun, Mar 17, 2002 at 12:15:23AM -0600 References: <20020317001523.A95530@marvin.bsdng.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--5vNYLRcllDrimb99 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 17, 2002 at 12:15:23AM -0600, Kyle Martin wrote: > enjoy :) I will, I promise! :) Just let me stick in a couple of comments first.. > # This is a shell archive. Save it in a file, remove anything before > # this line, and then unpack it by entering "sh file". Note, it may > # create directories; files and directories will be owned by you and > # have default permissions. > # > # This archive contains: > # > # . > # ./Makefile > # ./distinfo > # ./cmake.shar > # ./pkg-descr > # ./pkg-comment > # ./pkg-plist It might be better and easier for all of us if you did not create the archive from the current directory, but placed all the port's files into a subdirectory and archived that. This would be both easier and less error-prone - for example, it would avoid shar(1)'s creating a recursive archive an incomplete cmake.shar :) Other than that, your port looks quite fine. However, what do you think about the attached patch to fix the last minor problems? - put tabs instead of spaces in the Makefile header; - use PORTVERSION instead of hardcoding the version all over the place; - use GNU_CONFIGURE instead of HAS_CONFIGURE; - add an URL to the pkg-descr file; - add a couple of files to the packing list :) Other than that, great work! G'luck, Peter --=20 Peter Pentchev roam@ringlet.net roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 This sentence claims to be an Epimenides paradox, but it is lying. diff -urN cmake/Makefile cmake-roam/Makefile --- cmake/Makefile Tue Mar 19 12:02:33 2002 +++ cmake-roam/Makefile Tue Mar 19 12:43:08 2002 @@ -1,6 +1,6 @@ -# New ports collection makefile for: cmake -# Date created: March 18 2002 -# Whom: Kyle Martin <mkm@ieee.org> +# New ports collection makefile for: cmake +# Date created: March 18 2002 +# Whom: Kyle Martin <mkm@ieee.org> # # $FreeBSD$ # @@ -9,11 +9,11 @@ PORTVERSION=3D 1.2 CATEGORIES=3D devel MASTER_SITES=3D http://www.cmake.org/ -DISTNAME=3D CMake1.2-src-unix +DISTNAME=3D CMake${PORTVERSION}-src-unix =20 MAINTAINER=3D mkm@ieee.org =20 -WRKSRC=3D ${WRKDIR}/CMake-1.2 -HAS_CONFIGURE=3D yes +WRKSRC=3D ${WRKDIR}/CMake-${PORTVERSION} +GNU_CONFIGURE=3D yes =20 .include <bsd.port.mk> diff -urN cmake/pkg-descr cmake-roam/pkg-descr --- cmake/pkg-descr Tue Mar 19 12:02:33 2002 +++ cmake-roam/pkg-descr Tue Mar 19 12:09:16 2002 @@ -1 +1,3 @@ A cross-platform make. + +WWW: http://www.cmake.org/ diff -urN cmake/pkg-plist cmake-roam/pkg-plist --- cmake/pkg-plist Tue Mar 19 12:02:33 2002 +++ cmake-roam/pkg-plist Tue Mar 19 12:41:51 2002 @@ -1,4 +1,6 @@ +bin/ccmake bin/cmake +bin/ctest share/CMake/Modules/Dart.cmake share/CMake/Modules/Documentation.cmake share/CMake/Modules/FindCABLE.cmake --5vNYLRcllDrimb99 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iEYEARECAAYFAjyXF8YACgkQ7Ri2jRYZRVNCkACeMn5EJDONC/LWJfmcDXOvjmxm JkUAnA39/j5A4lb5KOxDWgUX+DJ0Z3YW =VWy2 -----END PGP SIGNATURE----- --5vNYLRcllDrimb99-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020319124942.A4570>