Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 11 Aug 2014 07:28:27 +0200
From:      John Marino <freebsd.contact@marino.st>
To:        Andrej Zverev <az@freebsd.org>, John Marino <marino@freebsd.org>
Cc:        "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>
Subject:   Re: svn commit: r364581 - in head/www: . p5-Dancer-Plugin-Lexicon
Message-ID:  <53E8547B.5020703@marino.st>
In-Reply-To: <CAD5bB%2Bhd4R3eCqqxJO=0CcOZR-tPR2fExf6NRN-0OZ51ZgD7-w@mail.gmail.com>
References:  <53e7f525.2d6d.2af7441e@svn.freebsd.org> <CAD5bB%2Bhd4R3eCqqxJO=0CcOZR-tPR2fExf6NRN-0OZ51ZgD7-w@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 8/11/2014 05:57, Andrej Zverev wrote:
> Hi,
> 
> WWW line is wrong here:
> - 99% of p5-* ports contain link to search.cpan.org, so please respect
> this fact.

It's not my port, I'm just committing one that passed all build tests
and looked visually correct.  I have no idea what a perl WWW is supposed
to look like.

> - You don't need hardcode  version number and author.

I don't know what you mean here.
I do this this got past me: "BUILD_DEPENDS:= ${RUN_DEPENDS}"


Look, the PR number is on the commit message.  You can alway post your
recommendations on the PR so the person who submitted the PR gets the
benefit.  It's lost on me.

John

> 
> On Mon, Aug 11, 2014 at 2:41 AM, John Marino <marino@freebsd.org> wrote:
>> Author: marino
>> Date: Sun Aug 10 22:41:40 2014
>> New Revision: 364581
>> URL: http://svnweb.freebsd.org/changeset/ports/364581
>> QAT: https://qat.redports.org/buildarchive/r364581/
>>
>> Log:
>>   Add new port www/p5-Dancer-Plugin-Lexicon
>>
>>   PR:           192352
>>   Submitted by: Henk van Oers
>>
>>   Dancer::Plugin::Lexicon uses Locale::Maketext::Lexicon to provide I18N
>>   functionality to your Dancer application.
>>
>>   Translations are stored in PO or MO (compiled PO) gettext files in the
>>   "languages/" dir. You can generate or update your PO files by
>>   automatically extracting translatable strings from your code and
>>   templates with xgettext.pl.
>>
>>   The user's preferred language can be auto-detected from their browser
>>   settings, and the current language is automatically stored in the user's
>>   session. Including "lang=$lang_tag" in the query string change the
>>   user's language.
>>
>> Added:
>>   head/www/p5-Dancer-Plugin-Lexicon/
>>   head/www/p5-Dancer-Plugin-Lexicon/Makefile   (contents, props changed)
>>   head/www/p5-Dancer-Plugin-Lexicon/distinfo   (contents, props changed)
>>   head/www/p5-Dancer-Plugin-Lexicon/pkg-descr   (contents, props changed)
>>   head/www/p5-Dancer-Plugin-Lexicon/pkg-plist   (contents, props changed)
>> Modified:
>>   head/www/Makefile
>>
>> Modified: head/www/Makefile
>> ==============================================================================
>> --- head/www/Makefile   Sun Aug 10 22:38:53 2014        (r364580)
>> +++ head/www/Makefile   Sun Aug 10 22:41:40 2014        (r364581)
>> @@ -841,6 +841,7 @@
>>      SUBDIR += p5-Dancer-Logger-Log4perl
>>      SUBDIR += p5-Dancer-Plugin-ExtDirect
>>      SUBDIR += p5-Dancer-Plugin-Feed
>> +    SUBDIR += p5-Dancer-Plugin-Lexicon
>>      SUBDIR += p5-Dancer-Plugin-SiteMap
>>      SUBDIR += p5-Dancer-Plugin-ValidationClass
>>      SUBDIR += p5-Dancer-Session-Cookie
>>
>> Added: head/www/p5-Dancer-Plugin-Lexicon/Makefile
>> ==============================================================================
>> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
>> +++ head/www/p5-Dancer-Plugin-Lexicon/Makefile  Sun Aug 10 22:41:40 2014        (r364581)
>> @@ -0,0 +1,26 @@
>> +# Created by: Henk van Oers <hvo.pm@xs4all.nl>
>> +# $FreeBSD$
>> +
>> +PORTNAME=      Dancer-Plugin-Lexicon
>> +PORTVERSION=   0.06
>> +CATEGORIES=    www perl5
>> +MASTER_SITES=  CPAN
>> +MASTER_SITE_SUBDIR=    CPAN:DRTECH
>> +PKGNAMEPREFIX= p5-
>> +
>> +MAINTAINER=    hvo.pm@xs4all.nl
>> +COMMENT=       Flexible I18N using Locale::Maketext::Lexicon for Dancer apps
>> +
>> +LICENSE=       ART10 GPLv1
>> +LICENSE_COMB=  dual
>> +
>> +RUN_DEPENDS=   p5-Dancer>=1.3118:${PORTSDIR}/www/p5-Dancer \
>> +               p5-Locale-Maketext-Lexicon>0:${PORTSDIR}/devel/p5-Locale-Maketext-Lexicon \
>> +               p5-Package-Stash>0:${PORTSDIR}/devel/p5-Package-Stash \
>> +               p5-PathTools>0:${PORTSDIR}/devel/p5-PathTools
>> +BUILD_DEPENDS:=        ${RUN_DEPENDS}
>> +
>> +USES=          perl5
>> +USE_PERL5=     configure
>> +
>> +.include <bsd.port.mk>
>>
>> Added: head/www/p5-Dancer-Plugin-Lexicon/distinfo
>> ==============================================================================
>> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
>> +++ head/www/p5-Dancer-Plugin-Lexicon/distinfo  Sun Aug 10 22:41:40 2014        (r364581)
>> @@ -0,0 +1,2 @@
>> +SHA256 (Dancer-Plugin-Lexicon-0.06.tar.gz) = 4494b7057f66e6443d0df186b44db1ea3d30704b938b0998c9825631a1d8a645
>> +SIZE (Dancer-Plugin-Lexicon-0.06.tar.gz) = 14594
>>
>> Added: head/www/p5-Dancer-Plugin-Lexicon/pkg-descr
>> ==============================================================================
>> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
>> +++ head/www/p5-Dancer-Plugin-Lexicon/pkg-descr Sun Aug 10 22:41:40 2014        (r364581)
>> @@ -0,0 +1,14 @@
>> +Dancer::Plugin::Lexicon uses Locale::Maketext::Lexicon to provide I18N
>> +functionality to your Dancer application.
>> +
>> +Translations are stored in PO or MO (compiled PO) gettext files in the
>> +"languages/" dir. You can generate or update your PO files by
>> +automatically extracting translatable strings from your code and
>> +templates with xgettext.pl.
>> +
>> +The user's preferred language can be auto-detected from their browser
>> +settings, and the current language is automatically stored in the user's
>> +session. Including "lang=$lang_tag" in the query string change the
>> +user's language.
>> +
>> +WWW: https://metacpan.org/source/DRTECH/Dancer-Plugin-Lexicon-0.06
>>
>> Added: head/www/p5-Dancer-Plugin-Lexicon/pkg-plist
>> ==============================================================================
>> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
>> +++ head/www/p5-Dancer-Plugin-Lexicon/pkg-plist Sun Aug 10 22:41:40 2014        (r364581)
>> @@ -0,0 +1,5 @@
>> +%%PERL5_MAN3%%/Dancer::Plugin::Lexicon.3.gz
>> +%%SITE_PERL%%/Dancer/Plugin/Lexicon.pm
>> +%%SITE_PERL%%/%%PERL_ARCH%%/auto/Dancer/Plugin/Lexicon/.packlist
>> +@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Dancer/Plugin/Lexicon
>> +@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Dancer/Plugin
>>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53E8547B.5020703>