Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 05 Jan 2016 01:27:03 +0100
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Jason Unovitch <junovitch@FreeBSD.org>, Bernard Spil <brnrd@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r405241 - in head: Mk security/libressl-devel security/libressl-devel/files
Message-ID:  <1B31A52699E5508F1FEEC161@atuin.in.mat.cc>
In-Reply-To: <20160104230113.GA28336@Silverstone.nc-us.unovitch.com>
References:  <201601041354.u04Dscco007638@repo.freebsd.org> <86CFA9A7-6B53-44C5-9DD7-46B20BDD7B2E@gmail.com> <85351af2862b2156d648b0de89af2065@imap.brnrd.eu> <20160104230113.GA28336@Silverstone.nc-us.unovitch.com>

next in thread | previous in thread | raw e-mail | index | archive | help
--==========D3B73738AAB8CF263E2F==========
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline



+--On 4 janvier 2016 18:01:13 -0500 Jason Unovitch <junovitch@FreeBSD.org>
wrote:
| -----BEGIN PGP SIGNED MESSAGE-----
| Hash: SHA512
|=20
| On Mon, Jan 04, 2016 at 07:00:43PM +0100, Bernard Spil wrote:
|> On 2016-01-04 17:43, Jason Unovitch wrote:
|> > On January 4, 2016 8:54:38 AM EST, Bernard Spil <brnrd@FreeBSD.org>=20
|> > wrote:
|> >> Author: brnrd
|> >> Date: Mon Jan  4 13:54:38 2016
|> >> New Revision: 405241
|> >> URL: https://svnweb.freebsd.org/changeset/ports/405241
|> >>=20
|> >> Log:
|> >>  security/libressl-devel: Add next-stable LibreSSL 2.3 port
|> >>=20
|> >>    - Add security/libressl-devel for version 2.3.1
|> >>    - Including corrections for CVE-2015-3194/3195
|> >>    - Add support for multiple versions to bsd.openssl.mk
|> >>    - Add option to optionally install API man-pages (201462)
|> >>    - Disable silent rules output
|> >>=20
|> >>  Changes:
|> >>=20
|> >> -
|> >> =
ftp://ftp.openbsd.org/pub/OpenBSD/LibreSSL/libressl-2.3.0-relnotes.txt
|> >> -
|> >> =
ftp://ftp.openbsd.org/pub/OpenBSD/LibreSSL/libressl-2.3.1-relnotes.txt
|> >>=20
|> >>  PR:		201462
|> >>  Submitted by: 	adamw (201462)
|> >> Reviewed by:	vsevolod (mentor, maintainer), koobs (mentor), feld
|> >> (mentor)
|> >>  Approved by:	koobs (mentor), feld (mentor)
|> >>  Differential Revision:	https://reviews.freebsd.org/D3585
|> >>=20
|> >> Added:
|> >>  head/security/libressl-devel/
|> >>  head/security/libressl-devel/Makefile   (contents, props changed)
|> >>  head/security/libressl-devel/distinfo   (contents, props changed)
|> >>  head/security/libressl-devel/files/
|> >> head/security/libressl-devel/files/patch-crypto_asn1_tasn__dec.c
|> >> (contents, props changed)
|> >> head/security/libressl-devel/files/patch-crypto_rsa_rsa__ameth.c
|> >> (contents, props changed)
|> >> head/security/libressl-devel/files/patch-include_openssl_opensslv.h
|> >> (contents, props changed)
|> >>  head/security/libressl-devel/pkg-descr   (contents, props changed)
|> >>  head/security/libressl-devel/pkg-message   (contents, props changed)
|> >>  head/security/libressl-devel/pkg-plist   (contents, props changed)
|> >> Modified:
|> >>  head/Mk/bsd.openssl.mk
|> >>=20
|> >=20
|> > An 'svn copy libressl libressl-devel' would have been the appropriate
|> > starting point
|> > for this port.
|> >=20
|> > https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/
|> > ports.html#ports-qa-repocopy-when
|> >=20
|> > "19.4.1.
|> >=20
|> > When do we need a repository copy?
|> >=20
|> > When you want to add a port that is related to any port that is
|> > already in the tree in a separate directory, you have to do a
|> > repository copy. Hererelated=C2=A0means it is a different version or a
|> > slightly modified version. Examples =
areprint/ghostscript*=C2=A0(different
|> > versions) and=C2=A0x11-wm/windowmaker*=C2=A0(English-only and =
internationalized
|> > version).
|> >=20
|> > Another example is when a port is moved from one subdirectory to
|> > another, or when you want to change the name of a directory because
|> > the author(s) renamed their software even though it is a descendant of
|> > a port already in a tree."
|>=20
|> Thanks Jason,
|>=20
|> Noted! "discovered" svn cp after a while, sorry for that.
|>=20
|> Do I need to revert the commit and redo it proper?
|>=20
|> Kind regards,
|>=20
|> Bernard.
|=20
| Yes. See mat@'s guidance from December. It should be removed and added
| (with a copy).

Yes, in the close future, I will svn rm ports that have been svn add'ed
instead of the correct svn cp'ed.

--=20
Mathieu Arnold
--==========D3B73738AAB8CF263E2F==========
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQJ8BAEBCgBmBQJWiw3XXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I30UQAKiFBkBS6A/Kp3ZuSa5h669V
jjaSttIaL1MyglhCOzo8QpcCqI+N6LQcgJWD8pRTKqrKsAzEhbgbbRBFX4TA3H8g
5pBxqrRWf3GwRBwMZd6K6EmRPm8XFptXRjEui/S8X4EsBVVOikwIGRu2tw7W+6YU
4EdC57qqoCrQbX9oazJjW4eUUTXdwzci56Xs6IuAPFFqSe04qDlbypO1+60b2PlS
v0Kmel8uIShaYi3xWm7mDVeFdNlCSmSuyL1zAJIIqQWO4yIucylK9p2FMptrJdv8
ySm/w0cBvPUKhriDAtFnMcnokMheQR6q0TTPEe/PJwZ+3j/3pEnYJvHfVHDnmOxj
DSZr03QMbwbjSNTMs5cjRgcjWEvMjR3+/qmB77INUbbxT8XcLsvRRJQFN9Pb7D0Y
AW7SPvg65XET60W/co9Ht302Gzab0fTyeBTLTn18wRRCwhEZKDwDrQRG27Z7VV6V
rW3hHoN7+QcMh4hOFYDuhSU9dNG4vWu4cYgJAVtWQRIusV+iP9QXqPHOyXKqAR1u
BvD+sACvbvq1B/+/3pE8+QW8GUq9QPgnavPNavWqwxPgKWD4GdoBzLwSD6neJlJP
/HDu8YOWFRPpZVsnV1A3RXdAUowGCPICINzid/JJj9zf3MdrA25u7zUWZLTrpVt4
LEN2Kg39LVXxC5U73qIt
=cewp
-----END PGP SIGNATURE-----

--==========D3B73738AAB8CF263E2F==========--




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1B31A52699E5508F1FEEC161>