From owner-freebsd-bugs@FreeBSD.ORG Wed Jun 19 20:40:00 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 9075B625 for ; Wed, 19 Jun 2013 20:40:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 5E2251DA3 for ; Wed, 19 Jun 2013 20:40:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r5JKe0fl001935 for ; Wed, 19 Jun 2013 20:40:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r5JKe0Fn001923; Wed, 19 Jun 2013 20:40:00 GMT (envelope-from gnats) Resent-Date: Wed, 19 Jun 2013 20:40:00 GMT Resent-Message-Id: <201306192040.r5JKe0Fn001923@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Renato Botelho Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id BB2914D4 for ; Wed, 19 Jun 2013 20:36:16 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) by mx1.freebsd.org (Postfix) with ESMTP id AD2061D84 for ; Wed, 19 Jun 2013 20:36:16 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r5JKaGGU072078 for ; Wed, 19 Jun 2013 20:36:16 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r5JKaG6n072065; Wed, 19 Jun 2013 20:36:16 GMT (envelope-from nobody) Message-Id: <201306192036.r5JKaG6n072065@oldred.freebsd.org> Date: Wed, 19 Jun 2013 20:36:16 GMT From: Renato Botelho To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: kern/179733: lagg interfaces loses capabilities when protocol changes X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jun 2013 20:40:00 -0000 >Number: 179733 >Category: kern >Synopsis: lagg interfaces loses capabilities when protocol changes >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jun 19 20:40:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Renato Botelho >Release: 10-current >Organization: ESF >Environment: FreeBSD freebsd1.localdomain 10.0-CURRENT FreeBSD 10.0-CURRENT #2 r250859M: Wed May 22 10:15:21 BRT 2013 root@freebsd1.localdomain:/usr/obj/usr/src/sys/GENERIC amd64 >Description: When you change laggproto of a lagg interface, it loses all capabilities except VLAN_HWFILTER. I don't know if the patch I'm sending is the correct fix, but it worked on my test environment. >How-To-Repeat: # ifconfig lagg0 create # ifconfig lagg0 laggproto lacp laggport NIC1 laggport NIC2 # ifconfig lagg0 | grep capabilities capabilities=1389b # ifconfig lagg0 laggproto loadbalance capabilities=10000 >Fix: Index: sys/net/if_lagg.c =================================================================== --- sys/net/if_lagg.c (revision 252002) +++ sys/net/if_lagg.c (working copy) @@ -997,6 +997,7 @@ sc->sc_proto = lagg_protos[i].ti_proto; if (sc->sc_proto != LAGG_PROTO_NONE) error = lagg_protos[i].ti_attach(sc); + lagg_capabilities(sc); LAGG_WUNLOCK(sc); return (error); } >Release-Note: >Audit-Trail: >Unformatted: