From owner-cvs-all  Tue Aug 31 14:50:17 1999
Delivered-To: cvs-all@freebsd.org
Received: from rover.village.org (rover.village.org [204.144.255.49])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0C48914D2C; Tue, 31 Aug 1999 14:50:05 -0700 (PDT)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (harmony.village.org [10.0.0.6])
	by rover.village.org (8.9.3/8.9.3) with ESMTP id PAA09218;
	Tue, 31 Aug 1999 15:47:54 -0600 (MDT)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id PAA13885; Tue, 31 Aug 1999 15:47:30 -0600 (MDT)
Message-Id: <199908312147.PAA13885@harmony.village.org>
To: Nick Hibma <hibma@skylink.it>
Subject: Re: cvs commit: src/bin/rm rm.1 rm.c 
Cc: "Jeffrey J. Mountin" <jeff-ml@mountin.net>,
	John Hay <jhay@mikom.csir.co.za>, obrien@FreeBSD.org,
	cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
In-reply-to: Your message of "Tue, 31 Aug 1999 21:08:50 +0200."
		<Pine.BSF.4.10.9908312107060.6750-100000@heidi.plazza.it> 
References: <Pine.BSF.4.10.9908312107060.6750-100000@heidi.plazza.it>  
Date: Tue, 31 Aug 1999 15:47:30 -0600
From: Warner Losh <imp@village.org>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

In message <Pine.BSF.4.10.9908312107060.6750-100000@heidi.plazza.it> Nick Hibma writes:
: 	if ( !e || (fflag && errno == ENOENT)) {

Just to pick a style(9) nit, but the space before the ! is not
allowed.

: is equivalent to
: 	if (!(e=rmdir(p->fts_accpath)) || (fflag && errno == ENOENT)) {
: but does not hide the fact that the rmdir is executed in all cases.

If you are going to unhide all things like this, then you will have a
lot of work to do.  There are hundreds of places in the tree that do
things like this. :-(

Warner


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message