Date: Sat, 23 Feb 2013 09:48:32 +0000 From: Chris Rees <utisoft@gmail.com> To: Eitan Adler <lists@eitanadler.com>, Dmitry Marakasov <amdmi3@amdmi3.ru> Cc: ports@freebsd.org Subject: Re: CONFIGURE_ENV and CPPFLAGS Message-ID: <CADLo83_bb=WQyMxu1wqnVeHn6ncZ-cACTtcVXDDYAdCwUNg=QQ@mail.gmail.com> In-Reply-To: <CAF6rxgnoyNMvpa_RDZi8Rf4HpZ139KL=ZARP9tHOETbiJjU2rA@mail.gmail.com> References: <CAF6rxgnoyNMvpa_RDZi8Rf4HpZ139KL=ZARP9tHOETbiJjU2rA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 22 Feb 2013 23:46, "Eitan Adler" <lists@eitanadler.com> wrote:
>
> Can you please sanity check the following?
>
> commit 687519c34ad3423752268a0a20d079fda9cea8b2
> Author: Eitan Adler <lists@eitanadler.com>
> Date: Fri Feb 22 18:43:30 2013 -0500
>
> Using CONFIGURE_ENV for CPPFLAGS and
> LDFLAGS is not needed since r282433.
>
> PR: docs/174827
> Submitted by: Dominique Goncalves <dominique.goncalves@gmail.com
>
>
> diff --git a/en_US.ISO8859-1/books/porters-handbook/book.xml
> b/en_US.ISO8859-1/books/porters-handbook/book.xml
> index ef50257..c64cdc7 100644
> --- a/en_US.ISO8859-1/books/porters-handbook/book.xml
> +++ b/en_US.ISO8859-1/books/porters-handbook/book.xml
> @@ -5726,17 +5726,13 @@ IGNORE= may not be redistributed because of
> licensing reasons. Please visit <rep
> CPPFLAGS+= -I${LOCALBASE}/include
> LDFLAGS+= -L${LOCALBASE}/lib
>
> -GNU_CONFIGURE= yes
> -CONFIGURE_ENV= CPPFLAGS="${CPPFLAGS}" \
> - LDFLAGS="${LDFLAGS}"</programlisting>
> +GNU_CONFIGURE= yes</programlisting>
>
> <para>Of course, the code can be more compact if there are no
> more flags to pass to <command>configure</command>:</para>
>
> <programlisting>USE_GETTEXT= yes
> -GNU_CONFIGURE= yes
> -CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \
> - LDFLAGS="-L${LOCALBASE}/lib"</programlisting>
> +GNU_CONFIGURE= yes</programlisting>
> </sect2>
>
> <sect2>
>
I'm pretty sure this is correct, but we should do one final check with
Dmitry.
Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83_bb=WQyMxu1wqnVeHn6ncZ-cACTtcVXDDYAdCwUNg=QQ>