From owner-svn-src-stable@freebsd.org Thu Mar 15 15:46:20 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 71DAFF5BD10 for ; Thu, 15 Mar 2018 15:46:20 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E82DA876B3 for ; Thu, 15 Mar 2018 15:46:19 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: de39461f-2867-11e8-b951-f99fef315fd9 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound2.ore.mailhop.org (Halon) with ESMTPSA id de39461f-2867-11e8-b951-f99fef315fd9; Thu, 15 Mar 2018 15:45:21 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w2FFkF4L025941; Thu, 15 Mar 2018 09:46:15 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1521128775.99081.34.camel@freebsd.org> Subject: Re: svn commit: r330972 - stable/11/share/misc From: Ian Lepore To: rgrimes@freebsd.org, Andriy Gapon Cc: Eitan Adler , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Date: Thu, 15 Mar 2018 09:46:15 -0600 In-Reply-To: <201803151533.w2FFXkS9093662@pdx.rh.CN85.dnsmgr.net> References: <201803151533.w2FFXkS9093662@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 15:46:20 -0000 On Thu, 2018-03-15 at 08:33 -0700, Rodney W. Grimes wrote: > > > > On 15/03/2018 10:30, Eitan Adler wrote: > > > > > > Author: eadler > > > Date: Thu Mar 15 08:30:05 2018 > > > New Revision: 330972 > > > URL: https://svnweb.freebsd.org/changeset/base/330972 > > > > > > Log: > > >   MFC r303063,r311852,r311930,r317040,r320506,r321301,r325162,r326759,r329004,: > > I have never seen things like these MFC-ed before... > > Should we be really doing them? > Yes, imho.  And the reasons may seem odd to sum, but here is my spin on this: > > It should not of been Eitan who did the MFC. > > Second, this simple document MFC is excellent training ground for a new > commiter to learn how to do a MFC.  Everyone should know how to do an MFC > and it seems we have many (me included when I returned as my experiece was > all with cvs, not svn) who do not know how to do this operation. > > If they mess up this simple text file it has a very low risk, and then > they can learn how to do a revert and recommit! > > Maybe we should even add to the end of the commiters "these are the > things you should do as a new committer" the merging of your info > into to all supported/active releases.  Which is a good opportunity > for teaching how to do svn sparse checkouts as you really do not > want to pull all of stable/10 out just to commit to 1 file. > > This file is an excellent opportunity for training, lets USE IT! > > Thanks, I agree completely with all of this. It bothers me how many committers have the attitude that handling MFCs is not part of being a committer. While I stop short of any kind of inflexible rule requiring all committers to attend to their own MFCs, anything we can do to encourage it and make it part of the culture is a good thing. -- Ian