Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 25 Nov 2021 23:21:24 +0000
From:      Pau Amma <pauamma@gundo.com>
To:        Warner Losh <imp@bsdimp.com>
Cc:        freebsd-git <freebsd-git@freebsd.org>
Subject:   Re: CI Piplines
Message-ID:  <f14031a1827a36bb58210008d891ace5@gundo.com>
In-Reply-To: <CANCZdfqHgtmnUBZVUnb5yPoapK_uNfWHAHCC9t133GBtzBLAyQ@mail.gmail.com>
References:  <CANCZdfra4M7XsQWgbkoeo97KODwScdHqes_AS5CUtoxSpYzWkg@mail.gmail.com> <6e72c7e11f43c844f44b343f3aadf040@gundo.com> <CANCZdfqHgtmnUBZVUnb5yPoapK_uNfWHAHCC9t133GBtzBLAyQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2021-11-20 06:02, Warner Losh wrote:
> On Sat, Nov 13, 2021 at 12:16 PM Pau Amma <pauamma@gundo.com> wrote:
> 
>> It would be nice IMO to have something that upon submitting or 
>> updating
>> a phabricator doc review (or maybe even before that, eg when 
>> committing
>> to a documenter's local git clone) would do some or all of:
>> - checking for AsciiDoc markup errors
>> - checking for bad link targets
>> - optionally, based on individual preferences and document language,
>> checking spelling
>> - rendering, at least to HTML
>> - checking the result against accessibility guidelines (ideally, this
>> would use the AsciiDoc source for ease of interpretation and 
>> correction
>> of problems, but most accessibility checkers I know of only deal with
>> HTML, and some checks, like color and contrast, are only possible when
>> HTML and CSS are both available)
>> - reporting to the author in near real-time (an email within a few
>> minutes would probably be enough)
>> 
>> I don't know, however, whether that would take phabricator action, CI
>> action, or both.
> 
> Phabricator has the ability to kick off Jenkins runs.
> https://github.com/uber/phabricator-jenkins-plugin
> has what looks like the necessary plugin. And
> https://www.linkedin.com/pulse/using-phabricator-jenkins-git-continuous-automated-pre-commit-tayal
> has a walkthrough of setting it up. Would you be able to look into what 
> it
> would take
> to apply those instructions to our phabricator setup? We have a 'test'
> phabricator
> setup that I think you can get access to if you wanted to try to do all 
> the
> things
> listed above.

Thanks for the links.

I had a first look at the plugin, and 
https://github.com/uber/phabricator-jenkins-plugin#jenkins-setup says 
some of the configuration is on the Jenkins side, not the Phabricator 
side. So my first question is: does FreeBSD have a Jenkins sandbox as 
well? (If you don't know, who does?) And who do I ask for access to the 
Phabricator sandbox? phab-admin@, phabric-admin@, or whatever the email 
address for the Phabricator admin people is?

I also skimmed through 
https://www.linkedin.com/pulse/using-phabricator-jenkins-git-continuous-automated-pre-commit-tayal 
which seems to use a similar method, except it relies on Github instead 
of the plugin, so I'm setting it aside unless and until FreeBSD goes 
that route.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f14031a1827a36bb58210008d891ace5>