From owner-cvs-all@FreeBSD.ORG Wed Apr 25 18:01:54 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2E96016A404; Wed, 25 Apr 2007 18:01:54 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id A436813C448; Wed, 25 Apr 2007 18:01:53 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l3PI1lQY068100; Wed, 25 Apr 2007 14:01:50 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Nate Lawson Date: Wed, 25 Apr 2007 13:56:35 -0400 User-Agent: KMail/1.9.6 References: <20070425162233.8CCFC16A59E@hub.freebsd.org> <462F8672.7040200@root.org> In-Reply-To: <462F8672.7040200@root.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200704251356.35785.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 25 Apr 2007 14:01:50 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3161/Wed Apr 25 11:52:16 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/acpica acpi.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2007 18:01:54 -0000 On Wednesday 25 April 2007 12:48:50 pm Nate Lawson wrote: > John Baldwin wrote: > > jhb 2007-04-25 16:22:18 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/acpica acpi.c > > Log: > > Use a tighter check to see if a resource allocation request is for a > > specific request and thus should first try to be allocated from the > > sys_resource pool. This avoids using the sys_resource pool for wildcard > > requests that have bounded ranges coming from cbb(4) and Host-PCI pcib(4) > > drivers. > > > > Tested by: Andrea Bittau > > Sleuthing by: Andrea Bittau as well > > > > Revision Changes Path > > 1.235 +1 -1 src/sys/dev/acpica/acpi.c > > > > > > Index: src/sys/dev/acpica/acpi.c > > diff -u src/sys/dev/acpica/acpi.c:1.234 src/sys/dev/acpica/acpi.c:1.235 > > --- src/sys/dev/acpica/acpi.c:1.234 Thu Mar 22 18:16:40 2007 > > +++ src/sys/dev/acpica/acpi.c Wed Apr 25 16:22:18 2007 > > @@ -1034,7 +1034,7 @@ > > * the request from our system resource regions. If we can't, pass the > > * request up to the parent. > > */ > > - if (!(start == 0UL && end == ~0UL) && rm != NULL) > > + if (start + count - 1 == end && rm != NULL) > > res = rman_reserve_resource(rm, start, end, count, flags & ~RF_ACTIVE, > > child); > > if (res == NULL) { > > I think I'll test this to see if it helps my via 8235 ata survive boot. I wonder if in fact the algorithm shouldn't be changed to always try to alloc the resource from the parent first, and only fall back to the sys_resource rmans if that fails? In theory any resource requests that should be done via sys_resource will fail the request in the parent, yes? -- John Baldwin