From owner-freebsd-net  Thu Oct 11 11:45:52 2001
Delivered-To: freebsd-net@freebsd.org
Received: from iguana.aciri.org (iguana.aciri.org [192.150.187.36])
	by hub.freebsd.org (Postfix) with ESMTP id 1188737B406
	for <freebsd-net@FreeBSD.ORG>; Thu, 11 Oct 2001 11:45:51 -0700 (PDT)
Received: (from rizzo@localhost)
	by iguana.aciri.org (8.11.3/8.11.1) id f9BIglx12911;
	Thu, 11 Oct 2001 11:42:47 -0700 (PDT)
	(envelope-from rizzo)
From: Luigi Rizzo <rizzo@aciri.org>
Message-Id: <200110111842.f9BIglx12911@iguana.aciri.org>
Subject: Re: review of change to bridge.h
In-Reply-To: <20011011114158.G84793-100000@wonky.feral.com> from Matthew Jacob at "Oct 11, 2001 11:42:30 am"
To: mjacob@feral.com
Date: Thu, 11 Oct 2001 11:42:47 -0700 (PDT)
Cc: rizzo@aciri.org, freebsd-net@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL43 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-net.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-net>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-net>
X-Loop: FreeBSD.org

> 
> Maybe bcmp is right. I believe having IS_ETHER_BROADCAST is too
> useful a macro....

yes, i mean leave it as a macro which calls bcmp, and
let the compiler handle the issue.

#define IS_ETHER_BROADCAST(a)	(!bcmp(a, "\377\377\377\377\377\377", 6))

	luigi

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message