From owner-svn-src-head@freebsd.org  Wed Oct 14 23:23:54 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6FDE4A155D5;
 Wed, 14 Oct 2015 23:23:54 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: from mail-qg0-x235.google.com (mail-qg0-x235.google.com
 [IPv6:2607:f8b0:400d:c04::235])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2F363F25;
 Wed, 14 Oct 2015 23:23:54 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: by qgx61 with SMTP id 61so57358246qgx.3;
 Wed, 14 Oct 2015 16:23:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=l09dWZ9bFwmcNiN3Nd1jtJwrEq52yt7R75vYSqECsTw=;
 b=Tg7dTORStK8NwOynaQzPjQp0UckKdocPVE7+Uutw+AZj8zYNmzjrZT7RVUrut+2Gf9
 kjEAl8C3h3hL1wk15Hkot334vubm3RIx58qRWP/zzCFCJeFkcqyxPJeTPgb+B7LyE4qq
 xpd0iwT+DImNlq62WpJs4x0+u7CFiqj/hgLcFoPvOkx2XoDcdi6BaxFTtjYXEk+1+kSv
 2J+/vrf8SjslDDbEfLdOpbhozMkdhU9+K5W3OZAtXd8dphkHHMX+85prPpE4sITI/aEb
 KHZPpot5V4m2z3EDmRX2i9NBtJq1JO5gB4b2kI/eJbV8QokHhH6O8ggWiih2P8C2KoZh
 L1NA==
MIME-Version: 1.0
X-Received: by 10.140.217.70 with SMTP id n67mr8012638qhb.96.1444865033223;
 Wed, 14 Oct 2015 16:23:53 -0700 (PDT)
Received: by 10.140.88.180 with HTTP; Wed, 14 Oct 2015 16:23:53 -0700 (PDT)
In-Reply-To: <561ED2B3.4030909@FreeBSD.org>
References: <201510142030.t9EKUWNY089355@repo.freebsd.org>
 <561ED2B3.4030909@FreeBSD.org>
Date: Wed, 14 Oct 2015 16:23:53 -0700
Message-ID: <CAGHfRMB31sZ_9K2mSt-2d8uVZKMq7jzR8U23JTcUtFYjWzNDzw@mail.gmail.com>
Subject: Re: svn commit: r289334 - head/share/mk
From: NGie Cooper <yaneurabeya@gmail.com>
To: Bryan Drewery <bdrewery@freebsd.org>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Oct 2015 23:23:54 -0000

On Wed, Oct 14, 2015 at 3:09 PM, Bryan Drewery <bdrewery@freebsd.org> wrote:
...
> So the reason I have been tinkering with this code is because it is so
> mysterious to me, given the lack of comments and seemingly out-of-place
> nature of it.
>
> It turns out that even moving 'buildconfig' as a recurse target creates
> a surprising situation that will break with parallel builds since
> 'buildconfig' is hooked into 'all', thus 'all' and 'buildconfig' both
> end up recursing when calling 'make all'. This explains the make() check
> here to avoid recursing if called with 'all' (even though it is checking
> the opposite, only calling 'buildconfig' directly to recurse).  Comments
> are not a sin.

Agreed.

The original change was done over a decade ago:
https://svnweb.freebsd.org/base/head/share/mk/bsd.subdir.mk?r1=96667&r2=96668&pathrev=289334&
. It seems that the targets used to have different names and ru@
changed them.

Succinct comments would probably be a good idea in the .mk files. I'm
not sure what the performance is like if bmake needs to
(re-)read/(re-)evaluate make snippets.

Thanks!
-NGie