From owner-freebsd-bugs@FreeBSD.ORG Fri Mar 31 08:20:20 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0CADA16A422 for ; Fri, 31 Mar 2006 08:20:20 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7BEAB43D48 for ; Fri, 31 Mar 2006 08:20:19 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2V8KJVg034389 for ; Fri, 31 Mar 2006 08:20:19 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k2V8KJDn034388; Fri, 31 Mar 2006 08:20:19 GMT (envelope-from gnats) Resent-Date: Fri, 31 Mar 2006 08:20:19 GMT Resent-Message-Id: <200603310820.k2V8KJDn034388@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6522D16A429 for ; Fri, 31 Mar 2006 08:11:20 +0000 (UTC) (envelope-from candy@kgc.co.jp) Received: from nsx.kgc.co.jp (nsx.kgc.co.jp [210.163.35.34]) by mx1.FreeBSD.org (Postfix) with SMTP id B236843D46 for ; Fri, 31 Mar 2006 08:11:19 +0000 (GMT) (envelope-from candy@kgc.co.jp) Received: (qmail 78132 invoked from network); 31 Mar 2006 17:11:17 +0900 Received: from ssm.kgc.co.jp (210.163.35.37) by nsx.kgc.co.jp with SMTP; 31 Mar 2006 17:11:17 +0900 Received: (qmail 57334 invoked from network); 31 Mar 2006 17:11:17 +0900 Received: from unknown (HELO xxx.kgc.co.jp) (172.30.2.3) by mail.kgc.co.jp with SMTP; 31 Mar 2006 17:11:17 +0900 Received: (qmail 93188 invoked by uid 10100); 31 Mar 2006 08:11:17 -0000 Message-Id: <20060331081116.93187.qmail@xxx.kgc.co.jp> Date: 31 Mar 2006 08:11:16 -0000 From: To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/95146: [ipfw][patch]ipfw -p option handler is bogus X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: candy-sendpr@kgc.co.jp List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2006 08:20:20 -0000 >Number: 95146 >Category: bin >Synopsis: [ipfw][patch]ipfw -p option handler is bogus >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Mar 31 08:20:14 GMT 2006 >Closed-Date: >Last-Modified: >Originator: >Release: FreeBSD 6.0-RELEASE-p6 i386 >Organization: - >Environment: FreeBSD 5.4-R or FreeBSD 6.0-R >Description: bogus things happen if you type `ipfw -p /usr/bin/m4' ipfw fopen(3)s /usr/bin/m4 then pass the FILE pointer to /usr/bin/m4. >How-To-Repeat: # ipfw -p /usr/bin/m4 command is (null) : TMPDIR=/tmp: No such file or directory : COLUMNS=80: No such file or directory : FTP_PASSIVE_MODE=YES: No such file or directory : BLOCKSIZE=K: No such file or directory (snip) ipfw: preprocessor exited with signal 11 # >Fix: --- ipfw2.c.orig Fri Mar 31 16:45:23 2006 +++ ipfw2.c Fri Mar 31 17:05:15 2006 @@ -5099,8 +5099,11 @@ */ av += optind - 1; ac -= optind - 1; + if (ac == 1) { + errx(EX_USAGE, "no filename arguments"); + } av[ac-1] = NULL; - fprintf(stderr, "command is %s\n", av[0]); + /*fprintf(stderr, "command is %s\n", av[0]);*/ break; case 'q': >Release-Note: >Audit-Trail: >Unformatted: