From owner-cvs-all@FreeBSD.ORG Tue Jan 20 12:27:28 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B176816A4CF for ; Tue, 20 Jan 2004 12:27:28 -0800 (PST) Received: from mail1.speakeasy.net (mail1.speakeasy.net [216.254.0.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 64DA743D53 for ; Tue, 20 Jan 2004 12:26:17 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 4582 invoked from network); 20 Jan 2004 20:26:12 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 20 Jan 2004 20:26:12 -0000 Received: from 10.50.41.236 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i0KKQ3M0014480; Tue, 20 Jan 2004 15:26:05 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Nate Lawson , Maxim Sobolev Date: Tue, 20 Jan 2004 15:14:16 -0500 User-Agent: KMail/1.5.4 References: <20040118210712.2B8C616A528@hub.freebsd.org> <400BACBC.9090506@portaone.com> <20040120113536.P96919@root.org> In-Reply-To: <20040120113536.P96919@root.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200401201514.16136.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/i386 p4tcc.c src/sys/conf files.i386 options.i386 src/sys/i386/conf NOTES X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2004 20:27:28 -0000 On Tuesday 20 January 2004 02:40 pm, Nate Lawson wrote: > On Mon, 19 Jan 2004, Maxim Sobolev wrote: > > Nate Lawson wrote: > > > On Sun, 18 Jan 2004, Maxim Sobolev wrote: > > >> FreeBSD src repository > > >> > > >> Modified files: > > >> sys/conf options.i386 files.i386 > > >> sys/i386/conf NOTES > > >> Added files: > > >> sys/i386/i386 p4tcc.c > > >> Log: > > >> Add new CPU_ENABLE_TCC option, from NOTES: > > >> > > >> CPU_ENABLE_TCC enables Thermal Control Circuitry (TCC) found in some > > >> Pentium(tm) 4 and (possibly) later CPUs. When enabled and detected, > > >> TCC allows to restrict power consumption by using machdep.cpuperf* > > >> sysctls. This operates independently of SpeedStep and is useful on > > >> systems where other mechanisms such as apm(4) or acpi(4) don't work. > > >> > > >> Given the fact that many, even modern, notebooks don't work properly > > >> with Intel ACPI, this is indeed very useful option for notebook > > >> owners. > > >> > > >> Obtained from: OpenBSD > > >> MFC after: 2 weeks > > > > > > I can't seem to see where this was posted before committing. Please > > > coordinate power/thermal management code with me. I have an upcoming > > > cpufreq driver that will encapsulate all of these machdep CPU control > > > drivers, including SpeedStep and LongRun. It's not dependent on ACPI > > > although ACPI can use it for passive cooling. Also, your driver should > > > use /etc/power_profile to set a sysctl, not proliferate > > > performance/economy sysctls. Drop me a private email and we can figure > > > out how to coordinate. > > > > Sorry, I did not know that you are working on this. Please feel free to > > take p4tcc support and integrate it into your framework. > > When I merge in the cpufreq layer, I will convert existing drivers to use > it, including yours. For instance, we already have a LongRun driver. At > a minimum, I ask that you change the sysctl from "machdep.cpuperf.*" to > "machdep.p4tcc.*" or whatever since cpuperf is too generic a term for a > P4-only driver. This will also make RELENG_4 less ambiguous if you MFC > it. I hope to have cpufreq committed before 5.3 and thus the p4tcc > sysctls won't make it into a release. > > BTW, how are you going to MFC this driver without sys/kern/subr_power.c? I already MFC'd subr_power.c to 4.x as part of the ACPI backport for 4.9. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org