Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 03 Oct 2014 17:40:51 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 187926] New port: devel/liballium - Tor pluggable transports utility library
Message-ID:  <bug-187926-13-QKbAq4mJ9B@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-187926-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-187926-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D187926

--- Comment #32 from Jan Beich <jbeich@vfemail.net> ---
The distfile contains tests. They can be exposed by adding

  OPTIONS_DEFINE=3D TEST
  TEST_ALL_TARGET=3Dcheck

> MASTER_SITES=3D   GH

Redundant with USE_GITHUB.

> CFLAGS+=3D	-I${LOCALBASE}/include
> LDFLAGS+=3D	-L${LOCALBASE}/lib

What the flags are used for? Did you miss adding a port dependency?

> USE_AUTOTOOLS=3D	autoconf aclocal automake
...
> pre-configure:
> 	@(cd ${WRKSRC}; ./autogen.sh)

Either define USE_AUTOTOOLS=3D"autoconf:env aclocal:env ..." or get rid of
pre-configure target or convert to USES=3Dautoreconf.

Using automake also means the following

=3D=3D=3D=3D> Running Q/A tests (stage-qa)
Warning: 'lib/liballium-1.0.so.0.0.1' is not stripped consider trying
INSTALL_TARGET=3Dinstall-strip or using ${STRIP_CMD}

>	@${MKDIR} ${STAGEDIR}/${PREFIX}/share/licenses/${PKGNAME}
>	${INSTALL_DATA} ${WRKSRC}/COPYING ${STAGEDIR}${PREFIX}/share/licenses/${P=
KGNAME}

No need to have / (slash) after ${STAGEDIR} or at least keep consistency. A=
nd
wrap long lines to fit on 80 characters terminal.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-187926-13-QKbAq4mJ9B>