From owner-cvs-all Thu Mar 7 3:21:32 2002 Delivered-To: cvs-all@freebsd.org Received: from squall.waterspout.com (squall.waterspout.com [208.13.56.12]) by hub.freebsd.org (Postfix) with ESMTP id 97A3A37B416; Thu, 7 Mar 2002 03:21:23 -0800 (PST) Received: by squall.waterspout.com (Postfix, from userid 1050) id 9B9D79B08; Thu, 7 Mar 2002 06:21:17 -0500 (EST) Date: Thu, 7 Mar 2002 06:21:17 -0500 From: Will Andrews To: Mike Barcroft Cc: David O'Brien , Mark Murray , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/rwall rwall.c Message-ID: <20020307112117.GL53073@squall.waterspout.com> Mail-Followup-To: Mike Barcroft , David O'Brien , Mark Murray , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200203042027.g24KRc978637@freefall.freebsd.org> <20020307030244.B63484@dragon.nuxi.com> <20020307060920.C81803@espresso.q9media.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020307060920.C81803@espresso.q9media.com> User-Agent: Mutt/1.3.26i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Mar 07, 2002 at 06:09:20AM -0500, Mike Barcroft wrote: > This introduces a bug where fdopen() could attempt to open a bad file > descriptor in the case of an error with mkstemp(). That's true. But I don't think the previous statement should be restored... it makes more sense the way it's written now.. adding the check back would probably be appropriate, however. -- wca To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message