Date: Wed, 31 Dec 2014 21:12:47 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: svn-src-head@freebsd.org, Warner Losh <imp@FreeBSD.org>, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Dimitry Andric <dim@FreeBSD.org> Subject: Re: svn commit: r276488 - in head: share/mk sys/arm/broadcom/bcm2835 sys/conf Message-ID: <A002DA3A-0047-4F83-8896-25AEEBF489A3@gmail.com> In-Reply-To: <E041E7F2-CC45-4D7B-912F-E5F86772E44A@gmail.com> References: <201501010200.t01205Ge007058@svn.freebsd.org> <760D3407-921D-4249-9DC2-74610FA46920@FreeBSD.org> <27B917EC-CB35-4BF6-AB8F-4CBF56EC3E41@bsdimp.com> <E1FA7448-844B-4454-8C2C-5592198D0570@gmail.com> <FC1DD917-D28C-44B8-9BE8-45A57F4A9EA6@bsdimp.com> <E041E7F2-CC45-4D7B-912F-E5F86772E44A@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_769FD0CD-89E4-485A-AAD9-A89CF3A8F25B
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=windows-1252
On Dec 31, 2014, at 20:44, Garrett Cooper <yaneurabeya@gmail.com> wrote:
> On Dec 31, 2014, at 20:25, Warner Losh <imp@bsdimp.com> wrote:
=85
>> This change is wrong. bsd.sys.mk was eliminated on purpose, dammit.
>=20
> Sorry. Should have asked first. Now the build is broken on all =
architectures :/. What next?
Also, that code has been in there for over a decade. It seems a bit =
dangerous to remove it without at least a ports -exp or make tinderbox =
run=85
$ svn blame -r 231834 share/mk/bsd.kmod.mk | less
60963 peter # $FreeBSD$
60963 peter=20
60963 peter # Search for kernel source tree in standard places.
130835 pjd .for _dir in ${.CURDIR}/../.. ${.CURDIR}/../../.. =
${.CURDIR}/../../../.. \
183736 imp ${.CURDIR}/../../../../.. /sys /usr/src/sys
130835 pjd .if !defined(SYSDIR) && exists(${_dir}/kern/) && =
exists(${_dir}/conf/kmod.mk)
60963 peter SYSDIR=3D ${_dir}
60963 peter .endif
60963 peter .endfor
130835 pjd .if !defined(SYSDIR) || !exists(${SYSDIR}/kern/) || \
130835 pjd !exists(${SYSDIR}/conf/kmod.mk)
231834 imp .error Unable to locate the kernel source tree. Set =
SYSDIR to override.
60963 peter .endif
60963 peter=20
60965 peter .include "${SYSDIR}/conf/kmod.mk"
76861 kris=20
76861 kris .include <bsd.sys.mk>
[ngie@fuji-current-amd64 /usr/src.svn]$ svn log -r 76861
------------------------------------------------------------------------
r76861 | kris | 2001-05-19 16:18:21 -0700 (Sat, 19 May 2001) | 8 lines
Bring in the WARNS directive from NetBSD, localized in a new bsd.sys.mk
to avoid polluting sys.mk. This directive controls the addition of
compiler warning flags to CFLAGS in a relatively compiler-neutral =
manner.
The idea is that WARNS can be set in Makefile.inc or in individual
Makefiles as they become clean, to prevent the introduction of new
warnings in the code. -Werror is added by default
------------------------------------------------------------------------
--Apple-Mail=_769FD0CD-89E4-485A-AAD9-A89CF3A8F25B
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=signature.asc
Content-Type: application/pgp-signature;
name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQEcBAEBCgAGBQJUpNdPAAoJEMZr5QU6S73exq0IAKGcNTbygmwPecOLmcOZBycQ
WqX8sEdlgMrDlyItzv212Y38KX4gAUFDx/OBvZLMWZC/I/jO/6QTcNTZ7sIPfjFS
o5jhcc6hDK93EPryYWCKD0J8KJuH+SH1Dx/JXoK/4sVULqXchUYAEZh9DQ0KcyYG
wk6ZK/PWdt07jLWn63y5o5TxlTkpd7HAHVGtgyywFaMK+SHxF0NUn+Epvq/4/jwH
MnV86q+cq2lxDwqz2QtXVplzbNE/CMUfACGo3oZvQhmF8brcxuuPVxnnnNmf6cvm
emoJgE2e+aK9fnJXh7vCjeuxvImOklS+1uu848eYtLRPEXeuP7jn+WMGvVIUj/Q=
=XObL
-----END PGP SIGNATURE-----
--Apple-Mail=_769FD0CD-89E4-485A-AAD9-A89CF3A8F25B--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A002DA3A-0047-4F83-8896-25AEEBF489A3>