From owner-svn-src-head@FreeBSD.ORG Thu Jan 1 05:12:49 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DD4861B4D; Thu, 1 Jan 2015 05:12:49 +0000 (UTC) Received: from mail-pa0-x229.google.com (mail-pa0-x229.google.com [IPv6:2607:f8b0:400e:c03::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9FFE567AB3; Thu, 1 Jan 2015 05:12:49 +0000 (UTC) Received: by mail-pa0-f41.google.com with SMTP id rd3so22331839pab.0; Wed, 31 Dec 2014 21:12:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=o9i+G0aHqNUyxp0P+tDkA1hCnlgTZgvmAC/q1/K5GL8=; b=MhwcTcAut2N+5QfaqIN8E/fwfRyYPQiOA41SOEfxNfpKHwxGGwA1OyBd5Czlj19uEZ j79PFHrY+/M2+UD6XYho409lizPfqK1+uIJ2Q7+M0Tkn6QcC+uHnZMQDrl7qRlyM8N4L hZNQS/0Cp0aQvNYxXH+zaAffqh7HEQJVSH21CfAX/jhv4aWOcG+Xus5Tv2rCyeWJ5f8D tN9oWinZI/RovuJ6BEVi7g6ihljqden2oTj0rlnwoA6Gpg9U1ffN2VKO2ziGJST5ibVS qfOEl7qy9QRLiyIkXskQiFinCSIeZMsq2HerQS0QxE3CAM+TV1iQEcNNXRcNr8I6jLEB ohGQ== X-Received: by 10.68.102.5 with SMTP id fk5mr110412825pbb.136.1420089169166; Wed, 31 Dec 2014 21:12:49 -0800 (PST) Received: from ?IPv6:2601:8:ab80:7d6:dd49:3e60:daf8:2ea9? ([2601:8:ab80:7d6:dd49:3e60:daf8:2ea9]) by mx.google.com with ESMTPSA id h2sm26213990pat.20.2014.12.31.21.12.48 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 31 Dec 2014 21:12:48 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_769FD0CD-89E4-485A-AAD9-A89CF3A8F25B"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r276488 - in head: share/mk sys/arm/broadcom/bcm2835 sys/conf From: Garrett Cooper In-Reply-To: Date: Wed, 31 Dec 2014 21:12:47 -0800 Message-Id: References: <201501010200.t01205Ge007058@svn.freebsd.org> <760D3407-921D-4249-9DC2-74610FA46920@FreeBSD.org> <27B917EC-CB35-4BF6-AB8F-4CBF56EC3E41@bsdimp.com> To: Warner Losh X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, Warner Losh , svn-src-all@freebsd.org, src-committers , Dimitry Andric X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jan 2015 05:12:50 -0000 --Apple-Mail=_769FD0CD-89E4-485A-AAD9-A89CF3A8F25B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Dec 31, 2014, at 20:44, Garrett Cooper wrote: > On Dec 31, 2014, at 20:25, Warner Losh wrote: =85 >> This change is wrong. bsd.sys.mk was eliminated on purpose, dammit. >=20 > Sorry. Should have asked first. Now the build is broken on all = architectures :/. What next? Also, that code has been in there for over a decade. It seems a bit = dangerous to remove it without at least a ports -exp or make tinderbox = run=85 $ svn blame -r 231834 share/mk/bsd.kmod.mk | less 60963 peter # $FreeBSD$ 60963 peter=20 60963 peter # Search for kernel source tree in standard places. 130835 pjd .for _dir in ${.CURDIR}/../.. ${.CURDIR}/../../.. = ${.CURDIR}/../../../.. \ 183736 imp ${.CURDIR}/../../../../.. /sys /usr/src/sys 130835 pjd .if !defined(SYSDIR) && exists(${_dir}/kern/) && = exists(${_dir}/conf/kmod.mk) 60963 peter SYSDIR=3D ${_dir} 60963 peter .endif 60963 peter .endfor 130835 pjd .if !defined(SYSDIR) || !exists(${SYSDIR}/kern/) || \ 130835 pjd !exists(${SYSDIR}/conf/kmod.mk) 231834 imp .error Unable to locate the kernel source tree. Set = SYSDIR to override. 60963 peter .endif 60963 peter=20 60965 peter .include "${SYSDIR}/conf/kmod.mk" 76861 kris=20 76861 kris .include [ngie@fuji-current-amd64 /usr/src.svn]$ svn log -r 76861 ------------------------------------------------------------------------ r76861 | kris | 2001-05-19 16:18:21 -0700 (Sat, 19 May 2001) | 8 lines Bring in the WARNS directive from NetBSD, localized in a new bsd.sys.mk to avoid polluting sys.mk. This directive controls the addition of compiler warning flags to CFLAGS in a relatively compiler-neutral = manner. The idea is that WARNS can be set in Makefile.inc or in individual Makefiles as they become clean, to prevent the introduction of new warnings in the code. -Werror is added by default ------------------------------------------------------------------------ --Apple-Mail=_769FD0CD-89E4-485A-AAD9-A89CF3A8F25B Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUpNdPAAoJEMZr5QU6S73exq0IAKGcNTbygmwPecOLmcOZBycQ WqX8sEdlgMrDlyItzv212Y38KX4gAUFDx/OBvZLMWZC/I/jO/6QTcNTZ7sIPfjFS o5jhcc6hDK93EPryYWCKD0J8KJuH+SH1Dx/JXoK/4sVULqXchUYAEZh9DQ0KcyYG wk6ZK/PWdt07jLWn63y5o5TxlTkpd7HAHVGtgyywFaMK+SHxF0NUn+Epvq/4/jwH MnV86q+cq2lxDwqz2QtXVplzbNE/CMUfACGo3oZvQhmF8brcxuuPVxnnnNmf6cvm emoJgE2e+aK9fnJXh7vCjeuxvImOklS+1uu848eYtLRPEXeuP7jn+WMGvVIUj/Q= =XObL -----END PGP SIGNATURE----- --Apple-Mail=_769FD0CD-89E4-485A-AAD9-A89CF3A8F25B--