From owner-freebsd-standards@FreeBSD.ORG  Tue Jul 29 09:17:36 2003
Return-Path: <owner-freebsd-standards@FreeBSD.ORG>
Delivered-To: freebsd-standards@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6180B37B401; Tue, 29 Jul 2003 09:17:36 -0700 (PDT)
Received: from vexpert.dbai.tuwien.ac.at (vexpert.dbai.tuwien.ac.at
	[128.131.111.2])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6E28743F75; Tue, 29 Jul 2003 09:17:35 -0700 (PDT)
	(envelope-from pfeifer@dbai.tuwien.ac.at)
Received: from [128.131.111.60] (acrux [128.131.111.60])
	by vexpert.dbai.tuwien.ac.at (Postfix) with ESMTP
	id EE59D1378A; Tue, 29 Jul 2003 18:17:33 +0200 (CEST)
Date: Tue, 29 Jul 2003 18:17:38 +0200 (CEST)
From: Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at>
To: Mike Barcroft <mike@freebsd.org>, freebsd-standards@freebsd.org
Message-ID: <Pine.BSF.4.56.0307291812390.17192@acrux.dbai.tuwien.ac.at>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: MFC sys/sys/socket.h, please?
X-BeenThere: freebsd-standards@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Standards compliance <freebsd-standards.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-standards>,
	<mailto:freebsd-standards-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-standards>
List-Post: <mailto:freebsd-standards@freebsd.org>
List-Help: <mailto:freebsd-standards-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-standards>,
	<mailto:freebsd-standards-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Jul 2003 16:17:36 -0000

Hi Mike/-standards,

may I ask you to MFC (part of) the following patch to sys/sys/socket.h?

  revision 1.67
  date: 2002/10/12 11:39:19;  author: mike;  state: Exp;  lines: +100 -17
  o Add typedefs for size_t and ssize_t.
  o Add typedefs for gid_t, off_t, pid_t, and uid_t in the non-standards
    case.
  o Add struct iovec (also defined in <sys/uio.h>).
  o Add visibility conditionals to avoid defining non-standard
    extentions in the standards case.
  o Change spelling of some types so they work without including
    <sys/types.h> (u_char -> unsigned char, u_short -> unsigned short,
    int64 -> __int64, caddr_t -> char *)
  o Add comments about missing restrict type-qualifiers and missing
    function.

Without this, the following small program fails to compile on -STABLE:

  #define _POSIX_SOURCE
  #include <sys/types.h>
  #include <sys/socket.h>

with the following warnings/errors:

  /usr/include/sys/socket.h:52: syntax error before `sa_family_t'
  /usr/include/sys/socket.h:52: warning: data definition has no type or storage class
  /usr/include/sys/socket.h:163: syntax error before `u_char'
  /usr/include/sys/socket.h:174: syntax error before `u_short'
  /usr/include/sys/socket.h:188: syntax error before `u_char'
  :

Gerald (gerald@FreeBSD.org)
-- 
Gerald "Jerry"   pfeifer@dbai.tuwien.ac.at   http://www.pfeifer.com/gerald/