From owner-freebsd-bugs@FreeBSD.ORG Wed Mar 20 19:40:01 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 8DF38F46 for ; Wed, 20 Mar 2013 19:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 6B70E67 for ; Wed, 20 Mar 2013 19:40:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r2KJe1Qw071496 for ; Wed, 20 Mar 2013 19:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r2KJe1NP071495; Wed, 20 Mar 2013 19:40:01 GMT (envelope-from gnats) Resent-Date: Wed, 20 Mar 2013 19:40:01 GMT Resent-Message-Id: <201303201940.r2KJe1NP071495@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, hiren panchasara Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id F15D1EE3 for ; Wed, 20 Mar 2013 19:35:05 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id C994DFD3 for ; Wed, 20 Mar 2013 19:35:05 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r2KJZ5OC021706 for ; Wed, 20 Mar 2013 19:35:05 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id r2KJZ5DQ021705; Wed, 20 Mar 2013 19:35:05 GMT (envelope-from nobody) Message-Id: <201303201935.r2KJZ5DQ021705@red.freebsd.org> Date: Wed, 20 Mar 2013 19:35:05 GMT From: hiren panchasara To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: kern/177153: [patch] Fixing clang warnings at /sys/ufs/ufs X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Mar 2013 19:40:01 -0000 >Number: 177153 >Category: kern >Synopsis: [patch] Fixing clang warnings at /sys/ufs/ufs >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Mar 20 19:40:01 UTC 2013 >Closed-Date: >Last-Modified: >Originator: hiren panchasara >Release: current >Organization: >Environment: 10.0-CURRENT FreeBSD 10.0-CURRENT #1 r248555: Wed Mar 20 15:00:20 UTC 2013 >Description: ===> ufs (all) /usr/src/sys/modules/ufs/../../ufs/ufs/ufs_quota.c:327:44: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare] if (dq->dq_curinodes != 0 && ncurinodes >= 0) ~~~~~~~~~~ ^ ~ /usr/src/sys/modules/ufs/../../ufs/ufs/ufs_quota.c:365:21: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare] ncurinodes >= 0) ~~~~~~~~~~ ^ ~ 2 warnings generated. >How-To-Repeat: cd /sys/modules/ufs make and you will see warnings from clang. >Fix: Index: sys/ufs/ufs/ufs_quota.c =================================================================== --- sys/ufs/ufs/ufs_quota.c (revision 248555) +++ sys/ufs/ufs/ufs_quota.c (working copy) @@ -324,7 +324,7 @@ DQI_WAIT(dq, PINOD+1, "chkiq1"); ncurinodes = dq->dq_curinodes + change; /* XXX: ncurinodes is unsigned */ - if (dq->dq_curinodes != 0 && ncurinodes >= 0) + if (dq->dq_curinodes != 0) dq->dq_curinodes = ncurinodes; else dq->dq_curinodes = 0; @@ -361,8 +361,7 @@ DQI_WAIT(dq, PINOD+1, "chkiq3"); ncurinodes = dq->dq_curinodes - change; /* XXX: ncurinodes is unsigned */ - if (dq->dq_curinodes != 0 && - ncurinodes >= 0) + if (dq->dq_curinodes != 0) dq->dq_curinodes = ncurinodes; else dq->dq_curinodes = 0; >Release-Note: >Audit-Trail: >Unformatted: