Date: Mon, 19 Jul 2004 09:25:56 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Brian Fundakowski Feldman <green@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys malloc.h src/sys/kern kern_malloc.c src/sys/vm vm_contig.c vm_page.h Message-ID: <200407190925.56489.jhb@FreeBSD.org> In-Reply-To: <20040719103917.GD1038@green.homeunix.org> References: <200407190621.i6J6LRWJ019976@repoman.freebsd.org> <20040719071147.GS18577@cs.rice.edu> <20040719103917.GD1038@green.homeunix.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 19 July 2004 06:39 am, Brian Fundakowski Feldman wrote: > On Mon, Jul 19, 2004 at 02:11:47AM -0500, Alan Cox wrote: > > On Mon, Jul 19, 2004 at 01:00:27AM -0600, Scott Long wrote: > > > This is a pretty darn big change to something that is so vital to so > > > many drivers (not including busdma, which means that this touches > > > nearly every driver). Who reviewed this? Was it discussed on a public > > > mailing list? What kind of testing was done for it? If you can't > > > answer these questions then I'm not terribly thrilled. > > > > I reviewed an earlier version of this and gave Brian some feedback. > > > > It is important to note that he added the new implementation side-by-side > > with the old. By default, the old implementation is still used. So, I > > wouldn't be too concerned. > > Aye, I didn't feel totally comfortable saying "Reviewed by:" since that > was a while ago, but between alc and hmp who has been overhauling the > contigmalloc() implementation in DFBSD there wasn't any concern that I > know I hadn't addressed (and Dillon ignored my solicitation). For future reference: In this case I usually add a line along the lines of: Reviewed by: bde (an earlier version) Which is both truthful and avoids the ensuing flamewar due to the appearance of an unreviewed driveby. :) -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200407190925.56489.jhb>