From owner-svn-src-all@freebsd.org Tue Dec 29 23:32:01 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 94796A54A25 for ; Tue, 29 Dec 2015 23:32:01 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qg0-x230.google.com (mail-qg0-x230.google.com [IPv6:2607:f8b0:400d:c04::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ED27106F for ; Tue, 29 Dec 2015 23:32:01 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qg0-x230.google.com with SMTP id 6so96583875qgy.1 for ; Tue, 29 Dec 2015 15:32:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=+CioRSG98vrrXNB/A4RUnhyspPEIlj6aO9Kr7jVtkfs=; b=0Jpb7hXaZ/oNFk4fynHhJnSp3aGaPF2CPS4WH/Nbt92xzAfqaKQU/7mryeTL7yXQ20 9bFU37XT1loIztADVihzyFlrk16TbLatKaVXJmBm6Bo+EGjRfuXryeA4rCo4bdPLL6Zc 5mn3SGeLSVgJsmKh1huOsAcpGZPBPVcps85WbIsLXJ/sC5MQbj8cGZ/N/LBOSqdMLPOb /v7P18xpI6wqzqiAHGr6Ul+FCNjQvti9oWsgYkZDiLQYoX/2fDAB46rDFIoLmb3Dzkxe cZw+CbZai6jvGXvarF8sf54UyOsC1JdMS1b0gXGfPb+FKEHriJxeWb79F5GynPHuCbeU aUUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=+CioRSG98vrrXNB/A4RUnhyspPEIlj6aO9Kr7jVtkfs=; b=lW9CPERWS0pZb3v4lEosJyRphpMwT+T+w8dlYrZH+yNsxrF1H/RSG2FVda/f9Bd5kG EXgKLXJn6qYQNpe8ZsqNMyi9fPO7/g2nsipTg58bOsVOG1RxSp/qyQfSPLQ5v4U52GJf UVcERBlbjH3yDz7GtCErbMGRRK3Cl+2XhEYEXz6Jbw2z6nLbhlCNQ8WAtvk4/SAVdWxn ZdMZeR8oj7yfNOVlasIM8HDigsMD6otiR315k1qKc8/4P8q/tLZNNS8k0XGz4jlb1pwr dHX9yZHI/sFwsVICbFNDXldYQM+Boym+R2JL2LL4DzjzBfAHNlkz+LmbpKZfstJBQWie kbfQ== X-Gm-Message-State: ALoCoQnP9ewEMZnMLu+iEqcGauJ+zSDPiTislY8bUrA5VK99ghuaeZqwxTzrbJIbd6ib0L4NkZUCK7H7ocNDSRFGzdhFVordcg== X-Received: by 10.140.165.16 with SMTP id l16mr86704008qhl.101.1451431920430; Tue, 29 Dec 2015 15:32:00 -0800 (PST) Received: from mutt-hardenedbsd (c-73-135-80-144.hsd1.md.comcast.net. [73.135.80.144]) by smtp.gmail.com with ESMTPSA id f7sm29873746qhf.7.2015.12.29.15.31.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Dec 2015 15:31:58 -0800 (PST) Date: Tue, 29 Dec 2015 18:31:56 -0500 From: Shawn Webb To: Gleb Smirnoff Cc: Konstantin Belousov , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r292772 - head/sys/vm Message-ID: <20151229233156.GA4032@mutt-hardenedbsd> References: <201512271442.tBREgdRr079655@repo.freebsd.org> <20151229205952.GV7277@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LZvS9be/3tNcYl/X" Content-Disposition: inline In-Reply-To: <20151229205952.GV7277@FreeBSD.org> X-Operating-System: FreeBSD mutt-hardenedbsd 11.0-CURRENT-HBSD FreeBSD 11.0-CURRENT-HBSD X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x6A84658F52456EEE User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Dec 2015 23:32:01 -0000 --LZvS9be/3tNcYl/X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 29, 2015 at 11:59:52PM +0300, Gleb Smirnoff wrote: > On Sun, Dec 27, 2015 at 02:42:39PM +0000, Konstantin Belousov wrote: > K> Author: kib > K> Date: Sun Dec 27 14:42:39 2015 > K> New Revision: 292772 > K> URL: https://svnweb.freebsd.org/changeset/base/292772 > K>=20 > K> Log: > K> Add missed relpbuf() for a smallfs page-in. > K> =20 > K> Reported by: Shawn Webb > K> Tested by: pho > K> Sponsored by: The FreeBSD Foundation > K>=20 > K> Modified: > K> head/sys/vm/vnode_pager.c > K>=20 > K> Modified: head/sys/vm/vnode_pager.c > K> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > K> --- head/sys/vm/vnode_pager.c Sun Dec 27 14:39:47 2015 (r292771) > K> +++ head/sys/vm/vnode_pager.c Sun Dec 27 14:42:39 2015 (r292772) > K> @@ -806,6 +806,7 @@ vnode_pager_generic_getpages(struct vnod > K> * than a page size, then use special small filesystem code. > K> */ > K> if (pagesperblock =3D=3D 0) { > K> + relpbuf(bp, freecnt); > K> for (i =3D 0; i < count; i++) { > K> PCPU_INC(cnt.v_vnodein); > K> PCPU_INC(cnt.v_vnodepgsin); >=20 > The reason for this bug is that I tried to move the (pagesperblock =3D=3D= 0) > block above the call to getpbuf(). >=20 > We actually know that filesystem is "small" at the very beginning of the > function and we can branch into "small filesystem" pager immediately. >=20 > Later I moved the block back to its place, simply because new place > wasn't tested properly. And forgot to restore relpbuf. >=20 > What filesystem did you use to show up the bug? I'm about to test the > variant with immediate branching. Shawn, would you be able to test > a patch if I produce one? Definitely. Send me a patch and I can spin up an ISO with it and boot it up in bhyve. Thanks, --=20 Shawn Webb HardenedBSD GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --LZvS9be/3tNcYl/X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWgxfqAAoJEGqEZY9SRW7uutAQAJmqARHqy6hjngzgxktCyGv4 nkZBcGj6UEZKUre3b4jH1Kq7AeD/Ymog+8NUQG5Dusy9JyoEI+ykSLVcZFy5Io6B NflOLVzefbEaJz/dkaWasDgfZHSpFzsAaGgjb1BdRNnD1AVZSQCGHw8uuMPVYhWV /IH/VIxz4eOcrsEDr+rkU5bKkmPmQpPQ9aLPWhxGZ0NNm9pBYhbY6LS/cDrJnP1T fp33rtI1PWB4+ZDuiiiNE44A7mzffUpSm9WH54B2y3BqkfUoD1qducTwMn8lsKbJ NJQWYG/o0DeLVtra/LT/5+OY2mTP+b3vmX1lT/E2wFKHHUjWzMJRHP8E7uQQQ3BB iLJGaO8QGAqjTmHunaGFC9N9qw0/0nXWLhcRq7+4bWkpm9zxQy3YCE8mt2gqFgaW yxqi24658dLejS/WiLhKoPZp9tFwt54EXUxcLZZYge25ckBzAwziJxoKDWKS3PzJ 4ZtzLWlSAT35ff3OmdiTPfoFL7Sxrv9SO6Zgv2MNj1RylwMkvTD/6ewFBQObDGCB q/DIqwmNBB/9lbnTgbO6YusfoZHijhw1qhHijefwSfqeMEZ9BQSh0AIyUHHQ4Mpp MMiFE3uvlZCRjg9u2Er7r8Fw4rTdx31wBS9kBv/CbgCYNqIfpY+WotemlFHEBiEi uEsL8t3BpNU3+fV99aMK =6R4R -----END PGP SIGNATURE----- --LZvS9be/3tNcYl/X--