Date: Wed, 20 Mar 2019 20:13:11 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: Alan Somers <asomers@freebsd.org> Cc: rgrimes@freebsd.org, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r345350 - in head: . lib/libjail sbin/mount_fusefs sys/conf sys/fs/fuse sys/modules sys/modules/fuse sys/modules/fusefs Message-ID: <201903210313.x2L3DB25058545@gndrsh.dnsmgr.net> In-Reply-To: <CAOtMX2gd-2Tyd-OWoqfUbnTB-mcHbb_uR4RoHoDVkzTx0_-CpA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Wed, Mar 20, 2019 at 4:01 PM Rodney W. Grimes > <freebsd@gndrsh.dnsmgr.net> wrote: > > > > > Author: asomers > > > Date: Wed Mar 20 21:48:43 2019 > > > New Revision: 345350 > > > URL: https://svnweb.freebsd.org/changeset/base/345350 > > > > > > Log: > > > Rename fuse(4) to fusefs(4) > > > > > > This makes it more consistent with other filesystems, which all end in "fs", > > > and more consistent with its mount helper, which is already named > > > "mount_fusefs". > > > > > > Reviewed by: cem, rgrimes > > > > I did not review this code, I made a single comment that > > it should be discussed on an applicable mail list (arch@) > > which you did do, and I thank you for that. > > > > I would of eventually objected to the "do not rename the source", > > as that is one of the sighted reasons we use svn, is it is near > > costless to do moves, and this just trades one missmatch for > > another, which in my book is a near nop. > > > > Reviews are still not being allowed enough world rotates > > before committing. I am presently abroad, with poor net, > > and busy. > > Sorry, I didn't realize you weren't done. What is the current acceptable "wait" time when asking a public list for a review/response to some operation? > But the other great thing > about SVN is that we can do stuff, and then do more stuff. Would you > like for me to rename the source files as well? I could do that. I suspect now that the code is committed, and that others have responded, maybe a proper amount of discussion shall occur and this decision made by more than 3 people. > The > one thing that I won't agree to do is to rename fuse_kernel.h => > fusefs_kernel.h, because that file comes verbatim from upstream and we > should keep the original name to make it easy to find(1). If this code comes from upstream we should try to maintain the same file names, in as many cases as we can. Did the commit made increase or decrease that miss match? Is there only one file from upstream? Does it make any since to set this code up as a vendor branch? Expect >24 hours between my replies from here forward. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201903210313.x2L3DB25058545>