Date: Sat, 23 Jul 2005 12:16:32 +0400 From: Andrey Chernov <ache@FreeBSD.ORG> To: "Greg 'groggy' Lehey" <grog@FreeBSD.ORG> Cc: Doug Barton <dougb@FreeBSD.ORG>, freebsd-current@FreeBSD.ORG Subject: Re: cvs commit: src/games/fortune/fortune fortune.c Message-ID: <20050723081631.GA33648@nagual.pp.ru> In-Reply-To: <20050723064449.GZ842@wantadilla.lemis.com> References: <200507230146.j6N1koqL061690@repoman.freebsd.org> <20050723015517.GA28428@nagual.pp.ru> <20050723020120.GV842@wantadilla.lemis.com> <42E1DFCE.6090506@FreeBSD.org> <20050723064449.GZ842@wantadilla.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--NzB8fVQJ5HfG6fxh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 23, 2005 at 04:14:49PM +0930, Greg 'groggy' Lehey wrote: > On Friday, 22 July 2005 at 23:12:30 -0700, Doug Barton wrote: > > Changing venue to -current, since these kinds of protracted discussions > > don't belong on the commit mailing lists. > > > > Greg 'groggy' Lehey wrote: > > > >> But for whatever reasons, many systems seem to have incorrect > >> random(4) initialization. > > > > I don't think it has anything to do with /dev/random initialization, I > > think that there is an error somewhere in the fortune code that is caus= ing > > this problem. >=20 > You should take a look at what I committed. It simply uses the > microsecond value returned by getlocaltime() for the automatic seeding > by srandomdev(). It fixes the problem. I can see only two > explanations: Well, I am not advocate /dev/random initialization bug in preference of=20 fortune bug. But your "fix" not fix _anything_ in _either_ case, for=20 fortune bug or for /dev/random bug. Better back it out and seek true bug.= =20 For fortune bug you can turn on DPRINTF at least and see what really=20 happens. Since I can't reproduce it, I can't help, only people who can=20 reproduce. --=20 http://ache.pp.ru/ --NzB8fVQJ5HfG6fxh Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iQCVAwUBQuH83+JgpPLZnQjrAQLDegQAiF/q7LWByUNOUg+penS2WJz5s+u6feuT FrKP8xf/1YOJwmwf0z3wkMxIHA6diVHEEUPkDQhHTryA+IquI8xbPDexmPyl/PfV Gxg9ajdGdVqadljmDx90mPEa+LP6E3fzOsWNSIHjZDMbc6+3KuWiHCBrAnfF6dor mvFdfpSyokg= =Vc2W -----END PGP SIGNATURE----- --NzB8fVQJ5HfG6fxh--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050723081631.GA33648>