Date: Thu, 04 Dec 2014 19:28:31 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: John-Mark Gurney <jmg@funkthat.com> Cc: Hans Petter Selasky <hps@selasky.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r275468 - head/sys/dev/usb/controller Message-ID: <86sigve0c0.fsf@nine.des.no> In-Reply-To: <20141204175032.GQ99957@funkthat.com> (John-Mark Gurney's message of "Thu, 4 Dec 2014 09:50:32 -0800") References: <201412032155.sB3LtjJN043364@svn.freebsd.org> <20141204005451.GM99957@funkthat.com> <54800B60.9020208@selasky.org> <20141204175032.GQ99957@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
John-Mark Gurney <jmg@funkthat.com> writes:
> Did you see the comment about usig __builtin_ffs{,l,ll} instead? this
> seems to be a better route...
No. It's needlessly compiler-dependent.
> So, how about changing libkern.h to define the various ones to the
> built in, and dropping all the special versions?
This is (or should) be taken care of in cpufunc.h for platforms that
support ffs / fls in hardware.
DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86sigve0c0.fsf>