From owner-freebsd-current@FreeBSD.ORG Wed Jul 14 13:01:23 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A2BF16A4CE; Wed, 14 Jul 2004 13:01:23 +0000 (GMT) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 87DD743D2F; Wed, 14 Jul 2004 13:01:22 +0000 (GMT) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.12.11/8.12.8) with ESMTP id i6ED1KVD008774 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 14 Jul 2004 17:01:21 +0400 (MSD) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.sick.ru (8.12.11/8.12.11/Submit) id i6ED1KX8008773; Wed, 14 Jul 2004 17:01:20 +0400 (MSD) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@freebsd.org using -f Date: Wed, 14 Jul 2004 17:01:20 +0400 From: Gleb Smirnoff To: Robert Watson Message-ID: <20040714130120.GA7897@cell.sick.ru> References: Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.6i cc: current@freebsd.org Subject: Re: Some netgraph node global locking patches X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2004 13:01:23 -0000 On Wed, Jul 14, 2004 at 12:30:40AM -0400, Robert Watson wrote: R> //depot/vendor/freebsd/src/sys/netgraph/ng_eiface.c R> //depot/vendor/freebsd/src/sys/netgraph/ng_fec.c R> //depot/vendor/freebsd/src/sys/netgraph/ng_iface.c Well, these three are quite straightforward and identical. Look fine. R> //depot/vendor/freebsd/src/sys/netgraph/ng_ppp.c Is there any hidden obstacles for merging qsort_r() from libc to libkern? It will help to remove this ugly hack. R> //depot/vendor/freebsd/src/sys/netgraph/ng_pppoe.c Agreed with comment. Anyway, I'm planning to move this configuration trigger to private data. sysctl's are not very elegant way to set configaration of netgraph node. Moreover, I can imagine setup when you need to serve non-standard PPPoE only on one interface, and normal PPPoE on other interfaces: for example two different networks merged to use one AC. R> //depot/vendor/freebsd/src/sys/netgraph/ng_tty.c R> +/* R> + * XXXRW: ngt_unit is protected by ng_tty_mtx. ngt_ldisc is constant once R> + * ng_tty is initialized. ngt_nodeop_ok is untouched, and might want to be a R> + * sleep lock in the future? R> + */ One question: are any locks held when linesw callbacks (ngt_open, ngt_close, etc..) are called? -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE