Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 17 Sep 2017 20:07:20 +0000 (UTC)
From:      Justin Hibbits <jhibbits@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r323687 - head/sys/powerpc/powerpc
Message-ID:  <201709172007.v8HK7K4m030298@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jhibbits
Date: Sun Sep 17 20:07:20 2017
New Revision: 323687
URL: https://svnweb.freebsd.org/changeset/base/323687

Log:
  Don't use a non-zero argument for __builtin_frame_address
  
  __builtin_frame_address with a non-zero argument is unsafe and rejected by
  newer gcc.  Since it doesn't seem to impact the stacktrace, don't bother
  with gymnastics to unwind to a different frame for starting.
  
  PR:		kern/220118
  MFC after:	2 weeks

Modified:
  head/sys/powerpc/powerpc/stack_machdep.c

Modified: head/sys/powerpc/powerpc/stack_machdep.c
==============================================================================
--- head/sys/powerpc/powerpc/stack_machdep.c	Sun Sep 17 19:54:27 2017	(r323686)
+++ head/sys/powerpc/powerpc/stack_machdep.c	Sun Sep 17 20:07:20 2017	(r323687)
@@ -110,6 +110,6 @@ stack_save(struct stack *st)
 {
 	register_t frame;
 
-	frame = (register_t)__builtin_frame_address(1);
+	frame = (register_t)__builtin_frame_address(0);
 	stack_capture(st, frame);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201709172007.v8HK7K4m030298>