Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 5 May 2006 03:40:45 GMT
From:      Kip Macy <kmacy@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 96679 for review
Message-ID:  <200605050340.k453ejmZ044884@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=96679

Change 96679 by kmacy@kmacy_storage:sun4v_rwbuf on 2006/05/05 03:40:00

	agressively use membars when setting the ipi ackmask and follow the 
	solaris convention of explicitly reloading on a mismatch

Affected files ...

.. //depot/projects/kmacy_sun4v/src/sys/sun4v/sun4v/interrupt.S#8 edit

Differences ...

==== //depot/projects/kmacy_sun4v/src/sys/sun4v/sun4v/interrupt.S#8 (text+ko) ====

@@ -427,13 +427,14 @@
 ENTRY(set_ackmask)
 	GET_PCPU_PHYS_SCRATCH(%g6)
 	wr	%g0, ASI_REAL, %asi
+	membar	#LoadStore|#StoreStore
 	lda	[%g3]%asi, %g1
 	lda	[PCPU(CPUMASK)]%asi, %g4
 1:	or	%g1, %g4, %g2
 	casa	[%g3]%asi, %g1, %g2
 	cmp	%g1, %g2
-	bne,pn	%icc, 1b
-	  mov	%g2, %g1
+	bne,a,pn %icc, 1b
+	  lda	[%g3]%asi, %g1
 	ba,a,pt	%xcc, cpu_mondo
-	  membar #StoreLoad
+	  membar #StoreLoad|#StoreStore
 END(set_ackmask)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200605050340.k453ejmZ044884>