From owner-svn-src-vendor@FreeBSD.ORG Mon Mar 22 10:58:16 2010 Return-Path: Delivered-To: svn-src-vendor@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 592BC1065675; Mon, 22 Mar 2010 10:58:16 +0000 (UTC) (envelope-from des@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 497A88FC1B; Mon, 22 Mar 2010 10:58:16 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o2MAwGrb000438; Mon, 22 Mar 2010 10:58:16 GMT (envelope-from des@svn.freebsd.org) Received: (from des@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o2MAwGba000436; Mon, 22 Mar 2010 10:58:16 GMT (envelope-from des@svn.freebsd.org) Message-Id: <201003221058.o2MAwGba000436@svn.freebsd.org> From: Dag-Erling Smorgrav Date: Mon, 22 Mar 2010 10:58:16 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-vendor@freebsd.org X-SVN-Group: vendor MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r205440 - vendor/openpam/dist/include/security X-BeenThere: svn-src-vendor@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the vendor work area tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Mar 2010 10:58:16 -0000 Author: des Date: Mon Mar 22 10:58:16 2010 New Revision: 205440 URL: http://svn.freebsd.org/changeset/base/205440 Log: Merge upstream r432: pam_end() already contains a NULL check, and it is not unreasonable to call it with a NULL pamh in a cleanup / error-handling situation. Remove OPENPAM_NONNULL, which may cause gcc to optimize away the NULL check. Modified: vendor/openpam/dist/include/security/pam_appl.h Modified: vendor/openpam/dist/include/security/pam_appl.h ============================================================================== --- vendor/openpam/dist/include/security/pam_appl.h Mon Mar 22 10:11:59 2010 (r205439) +++ vendor/openpam/dist/include/security/pam_appl.h Mon Mar 22 10:58:16 2010 (r205440) @@ -72,8 +72,7 @@ pam_close_session(pam_handle_t *_pamh, int pam_end(pam_handle_t *_pamh, - int _status) - OPENPAM_NONNULL((1)); + int _status); int pam_get_data(const pam_handle_t *_pamh,