Date: Sat, 4 Aug 2012 21:46:32 +0100 From: Attilio Rao <attilio@freebsd.org> To: Konstantin Belousov <kib@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r239040 - in head/sys: fs/nfsclient fs/nwfs fs/smbfs nfsclient vm Message-ID: <CAJ-FndBrerZ8%2BwwnyZ96nZSY8otdRAp31dVEhiStYFstNLLepw@mail.gmail.com> In-Reply-To: <201208041816.q74IGisk081197@svn.freebsd.org> References: <201208041816.q74IGisk081197@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 4, 2012 at 7:16 PM, Konstantin Belousov <kib@freebsd.org> wrote: > Author: kib > Date: Sat Aug 4 18:16:43 2012 > New Revision: 239040 > URL: http://svn.freebsd.org/changeset/base/239040 > > Log: > Reduce code duplication and exposure of direct access to struct > vm_page oflags by providing helper function > vm_page_readahead_finish(), which handles completed reads for pages > with indexes other then the requested one, for VOP_GETPAGES(). The semantic of this new function is very questionable as I don't think we have any other function that accepts error as in-parameter (in particular if it does only a check). The error check should really belong to the consumers IMHO (even if duplicate). Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndBrerZ8%2BwwnyZ96nZSY8otdRAp31dVEhiStYFstNLLepw>